demux_lavf: set duration to -1 if unknown #12457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@myspaghetti can you try testing with the mpv build from this PR to see if this fixes your issue? https://github.com/mpv-player/mpv/actions/runs/6265175874 |
llyyr
force-pushed
the
demux_lavf_duration
branch
from
255e1f4
to
a635eb0
Compare
|
Download the artifacts for this pull request: |
sfan5
reviewed
Sep 21, 2023
`demux->duration` is set to -1 on initialization, and some checks rely on it being -1 when unknown. Before this commit, we set `demux->duration` to 0 when unknown. This is incorrect and breaks rtsp logic for disabling seeking outside of cached regions. To fix these issues, initialize `total_duration` and `av_duration` at -1. They're only changed if a real duration is detected, so in cases where the duration is unknown, demux->duration is set to -1 correctly. Fixes: e6afc53 ("demux_lavf: get total duration from track durations")
llyyr
force-pushed
the
demux_lavf_duration
branch
from
a635eb0
to
975ceca
Compare
|
This build seeks correctly, thank you! (Playback is more jerky, frames are unnecessarily skipped when skipping or fast-forwarding, fps appears to be limited to stream fps instead of display fps, but this appears to be a different issue.) Thank you so much! You addressed this issue remarkably fast! |
|
More time was spent trying to get a working rtsp stream than figuring out the bug... Thanks for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
demux->durationis set to -1 on initialization, and some checks rely on it being -1 when unknown. Before this commit, we setdemux->durationto 0 when unknown. This is incorrect and breaks rtsp logic for disabling seeking outside of cached regions.To fix these issues, initialize
total_durationandav_durationat -1. They're only changed if a real duration is detected, so in cases where the duration is unknown, demux->duration is set to -1 correctly.Fixes: e6afc53 ("demux_lavf: get total duration from track durations")
Fixes #12454