Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ytdl_hook: propogate ytdl.path out so that mp.get_opt can see it #12852

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bitingsock
Copy link
Contributor

Allows other scripts to use ytdl.path without having to discover it themselves.

Allows other scripts to use ytdl.path without having to discover it themselves
Copy link

github-actions bot commented Nov 8, 2023

Download the artifacts for this pull request:

Windows

@sfan5
Copy link
Member

sfan5 commented Nov 8, 2023

  1. This is only set when ytdl_hook ran at least once, how useful is that for other scripts?
  2. IMO user-data is the better place to store this

@bitingsock
Copy link
Contributor Author

bitingsock commented Nov 9, 2023

Yes, I remembered only afterwards that the hook does not run unless needed. Likely not as useful as I had hoped.

@kasper93
Copy link
Contributor

kasper93 commented Nov 9, 2023

Could be useful for scripts like https://github.com/christoph-heinrich/mpv-quality-menu where you have to set ytdl_ver separately. I don't know what is the correct solution, but I guess there is little bit of value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants