command: add load-config-file and load-input-conf
#13288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
Dudemanguy
reviewed
Jan 21, 2024
guidocella
force-pushed
the
load-config
branch
from
0138e62
to
c30bd62
Compare
Unlike set include mpv.conf, this works after playback has started. It can be used to auto reload the configuration, e.g. in vim: autocmd BufWritePost ~/.config/mpv/mpv.conf silent !echo load-config-file %:p | socat - /tmp/mpvsocket Partially fixes mpv-player#6362.
This is unused since fb4d26e.
guidocella
force-pushed
the
load-config
branch
from
c30bd62
to
c778f5a
Compare
Dudemanguy
reviewed
Feb 3, 2024
Dudemanguy
approved these changes
Feb 4, 2024
This return value is only used to set bool config_ok in mp_input_load_config so it makes more sense to return bool.
This can be used to auto reload the input configuration file, e.g. in vim: autocmd BufWritePost ~/.config/mpv/input.conf silent !echo load-input-conf %:p | socat - /tmp/mpvsocket Partially fixes mpv-player#6362. Additionally this can be used as a replacement for deprecated input sections if they are ever actually removed. For example, if you want to define different bindings for images, you can load-input-conf an input.conf for images, and load the original again when switching to a video. Though currently you would have to redefine builtin bindings that were overwritten with image ones in the default input.conf.
guidocella
force-pushed
the
load-config
branch
from
c778f5a
to
b5b7158
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the commands
load-config-fileandload-input-conf. They can be used to auto reload configuration files, e.g. in vim:Partially fixes #6362. This is simpler than spawning a thread to observe changes to these files with inotify and doing the equivalent on each platform, but it relies on users configuring their text editor.