-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
win32: fix maximize state with --border=no #13721
Conversation
@na-na-hi: What do you think we do something like this for |
This is viable in principle as long as the states are correctly updated on state change request from both mpv and windows side. But currently it doesn't work and the title bar is shown when the window is maximized. Interestingly, there are some inconsistencies here between unmaximizing from mpv and windows side. If I unmaximize the window from windows side, window snapping works afterwards even though it doesn't normally with |
Yeah, this is already quite annoying for fullscreen and other states too.
It is |
Really? In this state, windows thinks it's unmaximized (any maximized state that got stuck for some reason goes away when I drag the window), mpv thinks it's unmaximized, and there are no corner rounding or borders at all (so not |
IIRC it happens when you resize maximized WS_POPUP window. It doesn't unmaximize itself. |
Download the artifacts for this pull request: |
ah, it still depended on --title-bar while it shouldn't. Now it should work correctly. |
The current version still has the symptom I described earlier, which you said wasn't a valid state:
|
WS_POPUP windows cannot be maximized, so instead of forcing it with unavoidable side-effects, change the window style before maximizing to make it work correctly.
@na-na-hi: needed to update style in WM_SIZE to account for external changes. Should be fine now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works.
WS_POPUP windows cannot be maximized, so instead of forcing it with unavoidable side-effects, change the window style before maximizing to make it work correctly.