Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ao/pulse: set similar properties as the pipewire backend #13724

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ao/pulse: set similar properties as the pipewire backend #13724

wants to merge 1 commit into from

Commits on Mar 19, 2024

  1. ao/pulse: set similar properties as the pipewire backend 

    Not setting `media.role` especially negatively affects wireplumber's
restore-stream feature as it will save different stream settings for
ao=pulse and ao=pipewire, so they will be restored differently.

For example:

 1. mpv --ao=pipewire ...
 2. mute the stream in pavucontrol
 3. mpv --ao=pulse ...
 4. note that the stream is not muted

To alleviate that issue, set `media.role` the same way it is set
in the pipewire audio backend. (As well as some others.)

See https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/3848
    @pobrn
    pobrn committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    20942a4 View commit details
    Browse the repository at this point in the history