-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
stats.lua: add codec profile #13841
stats.lua: add codec profile #13841
Conversation
Download the artifacts for this pull request: |
84a8dc8
to
7bd5462
Compare
Why did this become a draft? It worked fine. |
cd5e7a5
to
62a0c03
Compare
Previous version has been rejected on IRC. New version is available now. |
32191ed
to
4340e14
Compare
I would like to have it in this release, but if it don't get reviewed in time, we can drop it. So don't consider it blocking. |
f89bb97
to
9f7c638
Compare
Adds support for extracting codec profile. Old properties are redirected to new one and removed from docs. Likely will stay like that forever as there is no reason to remove them. As a effect of unification of properties between audio and video, video-codec will now print codec (format) descriptive name, not decoder long name as it were before. In practice this change fixes what docs says. If you really need decoder name, use the `track-list/N/decoder-desc`.
May be interesting information for users. Fixes: mpv-player#13839
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise for the new properties LGTM.
Not sure how much of an API promise we have regarding these existing properties, but at least the commit message now mentions that there are changes regarding {video,audio}-codec
's contents.
Coded description is unlikely to be used differently than just printing its value. For format matching the short name should be used. Also the new behavior arguably matches current documentation. (and the value of this prop has been changed not so long ago and there was no complaints) |
No description provided.