add multi-touch support #14003
Merged
add multi-touch support #14003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal of multitouch support is to interpret as little as possible: mpv just stores the touch point information and makes the position available for query. Does not participate in the deprecated input section system. The API is modeled after the common part of the touch input APIs of Win32, X11, and Wayland, to make sure the platform-specific implementations are as simple as possible.
|
Download the artifacts for this pull request: |
dyphire
referenced
this pull request
in dyphire/mpv-config
Apr 29, 2024
得益于 verygoodlee/mpv-menu-plugin@e59bf0f 提出的方法，现在可以切换到 mpv 的内部实现了 归档 C 插件
na-na-hi
force-pushed
the
multitouch
branch
2 times, most recently
from
1d04647
to
932c7ae
Compare
sfan5
reviewed
Apr 29, 2024
| { | ||
| // queue dummy cmd so that touch-pos can notify observers | ||
| mp_cmd_t *cmd = mp_input_parse_cmd(ictx, bstr0("ignore"), "<internal>"); | ||
| queue_cmd(ictx, cmd); |
There was a problem hiding this comment.
this seems to be necessary because mouse-pos is married to MP_EVENT_INPUT_PROCESSED which is triggered in mp_process_input. could be improved some day..
na-na-hi
force-pushed
the
multitouch
branch
3 times, most recently
from
7164ea8
to
baaf07a
Compare
sfan5
approved these changes
Apr 29, 2024
kasper93
reviewed
Apr 29, 2024
This adds touch-pos property, which contains the information of all current touch points. The property has sub properties: touch-pos/count: the number of current touch points touch-pos/N/x,y: the position of touch point N touch-pos/N/id: unique identifier of the touch point
This adds --input-touch-emulate-mouse option, which controls whether to enable legacy touch handling where touch inputs are emulated as mouse inputs. This establishes a primary touch point (the one with the lowest index) as the emulated mouse position, and MBTN_LEFT up/down with the appearance of the first touch point and the disappearance of the last touch point. This fixes some problems with touch handling on Wayland, for example attempting to pinch results in a double click.
Release all touch points. Used by some VOs like Wayland touch cancel event.
na-na-hi
force-pushed
the
multitouch
branch
2 times, most recently
from
786d1d5
to
a5e55a1
Compare
Use the multitouch API. No need to emulate mouse input as it's already done by the input system.
For platforms which send emulated mouse inputs for touch-unaware clients, such as Win32 and X11, this option enables the native multitouch handling and disables emulated mouse inputs. This enables interested scripts to handle multitouch events while keeping compatibility with touch-unaware scripts.
Use the multitouch API. To disable system's defualt mouse emulation, set --native-touch=yes.
kasper93
approved these changes
May 1, 2024
This was referenced May 1, 2024
This was referenced May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, mpv's input system has no real touch handling. Touch messages are either not requested, or very awkwardly translated to emulated mouse, which results in some bugs on Wayland and severely limits mpv's gesture recognition ability.
This adds multi-touch support to mpv, in the form of added
touch-posproperty, and implements the support for Win32 and Wayland. The property contains the positions of all current touch points, each corresponds to a finger on the touch surface. Scripts can implement custom gesture recognition algorithms to process these values and determine the appropriate action to perform.For compatibility,
--input-touch-emulate-mouseand--native-touchoptions are added to control whether touch events need to be emulated as mouse events.The following example script demonstrates the recognition of 2-finger vertical scroll gesture to control the video brightness: