Revert "stream: don't try to read from all-sparse/no-data files" #14125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stream layer is just not the right place to make this change since it's also used for completely unrelated purposes such as reading configs. This reverts commit bb7a485.
|
Download the artifacts for this pull request: |
kasper93
approved these changes
May 12, 2024
There was a problem hiding this comment.
The concern from the original review (#13817 (comment)) that returning an error for empty files might be unexpected for this API’s users seems valid. Rejecting empty files might be useful in some cases, but it needs to be implemented more carefully on the reader’s side to act accordingly. Unconditionally rejecting empty files on open is not valid, as mentioned in previous comments regarding the issues. This stream is used for various purposes, such as loading shader cache files, config files, and so on; empty files are not always an error.
Thus, the idea can be revisited with a more careful implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.