Drag and drop playlist append #2261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This takes care of the corner case where the player is started with a single playlist entry so that the next/prev arrows are greyed out, but remain that way even after new elements are added to the playlist.
This puts in place the machinery to merely append dropped file to the playlist instead of replacing the existing playlist. In this commit, all front-ends set this to false preserving the existing behaviour.
If the drag and drop action is anything other than XdndActionCopy, append the dropped files rather than replacing the existing playlist. With most file managers, this will mean at least pressing shift while dropping.
|
So is this mergeable with that modification? |
|
Sounds ok. If you want to bother, replace the bool parameter with an enum. |
|
merged with discussed revisions |
|
I see no merge, though. |
|
oops i just pushed the branch. fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #2166, this adds append to playlist functionality through a modified drag and drop.
I have started with just x11. In this PR all other platforms preserve the existing "replace" behaviour for now.
The only way I could find to achieve this is to use the Action member in the XdndPosition client message. This is typically XdndActionCopy, however Thunar, Nautilus and Dolphin change this to XdndActionMove if you press the shift key. Dolphin will additionally send XdndActionLink if you press alt. Therefore, XdndActionCopy corresponds to the existing "replace" behaviour, while anything else is considered "append".
This seems kind of hackish to me, but I can't figure out any way to determine the modifier keys at drop time directly since the mpv window does not have focus and none of the above file managers appear to send this information along in the XdndPosition as they are supposed to according to http://jjlindal.net/jafl/xdnd/.