Wayland rewrite #4945
Closed
Wayland rewrite #4945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This VO was buggy and never worked correctly. Like with wayland_common, it needs to be rewritten from scratch.
ddevault
reviewed
Oct 2, 2017
video/out/wayland_common.c
Outdated
| static void pointer_handle_axis(void *data, struct wl_pointer *wl_pointer, | ||
| uint32_t time, uint32_t axis, wl_fixed_t value) | ||
| { | ||
| } |
There was a problem hiding this comment.
Don't you need to implement this?
The wayland code was written more than 4 years ago when wayland wasn't even at version 1.0. This commit rewrites everything in a more modern way, switches to using the new xdg v6 shell interface which solves a lot of bugs and makes mpv tiling-friedly, adds support for drag and drop, adds support for touchscreens, adds support for KDE's server decorations protocol, and finally adds support for the new idle-inhibitor protocol. It does not yet use the frame callback as a main rendering loop driver, this will happen with a later commit.
|
Thanks for the review, pushed |
ghost
closed this
|
Tangentially, if anyone is still using mpv 0.27 and earlier on Gnome Shell then this shell fix solves clicking/moving/tiling issues too (without needing the rewrite in mpv 0.28): |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wayland code was written more than 4 years ago when wayland wasn't even at version 1.0. This commit rewrites everything in a more modern way, switches to using the new xdg v6 shell interface which solves a lot of bugs and makes mpv tiling-friedly, adds support for drag and drop, adds support for touchscreens and adds support for KDE's server decorations protocol.
Currently supported touchscreen events: two finger move, one finger scale (touch the edge of the window) and one-finger tapping to click.
It does not yet use the frame callback as a main rendering loop, this will happen with a later commit.
The protocol files are included in the repo because waf can't seem to use them from /usr/share/wayland-protocols.
I agree that my changes can be relicensed to LGPL 2.1 or later.