Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vo_gpu: desaturate after peak detection #5848

Merged
merged 1 commit into from May 31, 2018
Merged

Conversation

haasn
Copy link
Member

@haasn haasn commented May 23, 2018

This sacrifices some dynamic range for well-behaved sources, but
prevents catastrophic desaturation on badly mastered / too bright
sources. I think that's the better trade-off. This makes the
desaturation algorithm much "safer" to deploy by default, as well. One
could even argue going up to strength 1.0, which works better for some
sources but worse for others. But I think the current strength is the
best trade-off even after this change.

Ideally, you shouldn't need enter any text here, and your commit messages should
explain your changes sufficiently (especially why they are needed). Read
https://github.com/mpv-player/mpv/blob/master/DOCS/contribute.md for coding
style and development conventions. Remove this text block, but if you haven't
agreed to it before, leave the following sentence in place:

I agree that my changes can be relicensed to LGPL 2.1 or later.

This sacrifices some dynamic range for well-behaved sources, but
prevents catastrophic desaturation on badly mastered / too bright
sources. I think that's the better trade-off. This makes the
desaturation algorithm much "safer" to deploy by default, as well. One
could even argue going up to strength 1.0, which works better for some
sources but worse for others. But I think the current strength is the
best trade-off even after this change.
@jeeb
Copy link
Member

jeeb commented May 24, 2018

I shall re-read the IRC discussion logs from yesterday night tomorrow, and then most likely merge this if it all seems sane enough.

Copy link
Member

@jeeb jeeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The difference generally seems rather small in brightness. Things were a bit brighter before, now somewhat less bright. Will post some comparison shots.

@jeeb
Copy link
Member

jeeb commented May 31, 2018

  1. Kimi no Na Wa opening, --pause --start=47 (PQ, MaxCLL 777 nits, MaxFALL 370 nits)

  2. TravelXP sample seabed scene --pause --start=60 (HLG)

Shin Godzilla sample clip I created earlier just fails to have mostly any effect, although that to be honest is easily the worst mastered piece of HDR content I own (even lacks metadata).

@jeeb jeeb merged commit 5056777 into mpv-player:master May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants