[RFC] wayland: reconfigure cursor on pointer enter event #6480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On wayland the cursor has to be configured each time the pointer enters. Currently if the window (re)gains the focus, the pointer is not hidden, even when configured. After the mouse has been moved the pointer hides correctly. https://wayland.freedesktop.org/docs/html/apa.html#protocol-spec-wl_pointer: wl_pointer::enter - enter event ... When a seat's focus enters a surface, the pointer image is undefined and a client should respond to this event by setting an appropriate pointer image with the set_cursor request. Fixes mpv-player#6185. Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
t-8ch
changed the title
|
It should also be discussed, how to handle pointer enter events, while the hiding timer is active and how to handle the pointer configuration at startup. |
|
Nice. This is the one little thing about wayland mpv that has annoyed me for a while. Just one little inconsistency I noticed. With this PR, the cursor will reappear if you fullscreen a window in which it was hidden. This does not happen to me if I use the x11 backend. I don't think users should have their cursors reappear when entering fullscreen (only while leaving it), so matching the x11 behavior seems to be the correct approach to me. |
|
Obsoleted by the PR above. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On wayland the cursor has to be configured each time the pointer enters.
Currently if the window (re)gains the focus, the pointer is not hidden,
even when configured. After the mouse has been moved the pointer hides
correctly.
https://wayland.freedesktop.org/docs/html/apa.html#protocol-spec-wl_pointer:
Fixes #6185.
Signed-off-by: Thomas Weißschuh thomas@t-8ch.de
I agree that my changes can be relicensed to LGPL 2.1 or later.