-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup of default key bindings (second try) #973
Comments
The keys for next and previous chapter ( I rather use |
The The same applies to |
For chapters, I use Ctrl-Left/Right and the back/forward buttons on my mouse (BTN7/8), but both of those only work when there's a vo window. I have As for Also, I agree that some of the rarely used things like |
My personal list of mosy hated binds:
I always have to look these bind up in the manpage before use. Although I |
Maybe change chapters with |
Seems changing chapters is the most frequently used function here. I would also like the keys for previous/next chapter to be changed to more "intuitive" ones. I don't know how often would people use pgup/pgdn to seek a file back/forward for 10 minutes, but to me it seems much more useful to change those to previous/next chapter. But, there are no pgup/pgdn keys on a Mac keyboard...Maybe "[" and "]"? They are now binded to changing playback speed, which IMO are quite rarely used for most people. Maybe also consider change the multimedia keys PREVIOUS and NEXT to changing chapters instead of seeking back/forward for 1 minute. |
Nobody uses 'c' (except accidentally) - remove. Everyone agrees that OSD level cycling on 'o' is dumb, so map it to show_progress instead. Cycling the OSD level is now available on 'O'. No reason to ummap 'P' yet. Also see issue #973.
Removed Chapter seek should definitely remapped. Suggestions were:
I think Ctrl could be made work on most terminals, though. What keys does the mac have again? |
pgdn, pgup is accessible as fn+down, fn+up on small Mac keyboards. |
On Sunday 03 August 2014 12:19:16 wm4 wrote:
Lies. fn+up/down. I very much support this change. @/! is awful on non-US layouts. |
Pgdn, pgup are accessible vial Fn on small Mac keyboards and are found standalone on the wired USB keyboard.
Also, if I don't remember incorrectly, Ctrl+Left/Right by default switches spaces left and right on OS X (if you have set up spaces). |
|
(I did so too) |
I also have |
So what does this mean? Is pgup/pgdown good to go for chapters? |
Personally it's more preferable to map single keys for seeking chapters, not key combinations, or at least key combinations can be pressed with one hand. So I would agree to make Another suggestion aside from |
No, they're terrible. Some keyboards have them on the same key, and without shift it produces |
From my side - yes. Just like a for switching audio and s for subtitles. BTW the av/as delay shortcuts can go. The few who need them (I sometimes
|
What if when mpv was full screened, ESC would go back to being windowed, and pressing ESC again while windowed would exit mpv? |
As discussed in #973. Keep the old bindings for now; there's no reason to unmap them yet.
Remapped pgup/dwn, keeping the old chapter bindings.
Perhaps, but then the bindings would be stateful, which would require additional code and more effort from the user to understand how it works. |
Removed some bindings I deemed too obscure with commit 90ec333. |
I also have p mapped to show_progress. |
It'd be weird to have both
Opinions? |
For seeking I would prefer |
I replaced 10 second |
I actually like Also I use e.g I bound |
I'd be fine with reducing normal seeking to 5s (Personally I use 1s, which effectively make sit skip to the next/previous keyframes, but it sometimes gets "stuck" with some formats.)
I agree it should get a default binding, but I think these keys should remain normal precise seeks. |
Also could you keep, the bindings for next and previous chapter (@ and !), since you can not press fn+up or fn+down (on a mac) with one hand. |
It is great to see active development on a video player. I am an mplayer user and starting/occasional mpv user. I am probably expecting too much similarity between mpv and mplayer (as it is a different video player), and my critique comes a bit late, but I think that the following ideas may be worth putting into the discussion as mpv does not, it appears, stop being developed, which is a good thing! Were there important reasons to remove keys for adjusting contrast, brightness and so on? I have seen the statement that it is better to change it on the hardware, but that is not really an argument to remove the functionality. If it resulted in less code to maintain, this is a good (but not sufficient) argument. In general, my opinion is that there should be a very good reason for any change in the user interface, for any program. In this sense I also do not understand why it was necessary to change the 'o' key binding (OSD), or the ←/→ from a 10 s to a 5 s change. When any improvement is subjective or minor, I tend to respect the legacy. Am I getting old? |
Some things should be changed eventually to make them better. You'll never leave legacy or tech debt behind if you're resistant to change. While the whole key binding file could probably use an evaluation for each key, which would make adaption of that way easier (through a config option that uses the legacy bindings by default during some adaptation period, for example), some small band-aids are always nice if they don't hurt. The bindings to cycle video, audio (and subtitle) tracks for example are kind of obscure. I can never remember audio. And some bindings would probably benefit from having their opposite action with a shift modified (like cycling subtitles). |
@mvhulten The bindings are gone, but the functionality is still there, so you can restore them if you want. mpv provides a sample input.conf file that restores some of MPlayer's bindings: |
AFAIK they were not touched in the end. You can still change contrast, brightness and so on with 1-8 keys by default, and as far as I remember those were also the exact same keys used in mplayer. |
@AirPort Oh, you're right. I assumed they were gone because they were in |
Thank you all for the useful comments, both on the more philosophical issue (@FichteFoll) and for the practical tip (@rossy). @AirPort, you are right; I had the experience in the past that by default 0—8 don't do anything in mpv, but that is not the case now (mpv 0.14 on Ubuntu), so it's not an issue. |
The current state is not too bad, while changing the bindings would basically confuse every existing mpv user. But I'm still open for a redesign that makes the bindings significantly saner. But I feel like we can't just incrementally reassign individual keys over a couple of releases.
Gamma was considered more useful. |
Indeed, that would be awful. I believe it has to be an "everything at once" approach with the deprecation periods known by other software. As in, you add the new feature but it's disabled by default. Later (or at the same time) you add deprecation notices so that people have time to adapt. Then you change the default but have the old option still for some users until it gets completely removed at a later time. I still like the draft by @lachs0r in the other issue a lot: #103 (comment) (with a couple minor adjustments). This could definitely be used as a base. (Btw, am I the only one who prefers their down key to seek foward and their up key to seek backward? Same for chapters on page up/down. I mean, that's how they usually work with scrolling.) |
Another suggestion: Since page down and page up was mapped to chapters (good mapping btw), on media files without chapters there are meaningless. What about (re)map page down and page up to 10 minutes seek, but only if there are no chapters present? So they can always be used to navigate quickly in the media. |
Is this still relevant at this point, or are the keybindings pretty stable as of now? I personally do not think they need to be changed at this point. |
Do you refer to my post? This change does not force the user to change old behaviour, but instead provides more functionality in some cases, so I'd say this don't break any stable behaviour, but is simply a feature. |
mpv doesn't currently offer a way to make state-dependent keybindings outside of scripts. I'm not sure if it should either beyond the current toggle / cycle functionality. |
I thought that crossed my mind yesterday were key chords, where a sequence of keys could be assigned to an action much like vim bindings. I.e. A problem with that might be that currently the number keys are already occupied. If modal bindings existed, comparable to i3wm, they could be grouped into an "adjustments" mode or similar. Except for volume, as that needs to remain accessible. I know this is talking big as the implementation and the required changed to key bindings are considerably significant, but this is all about brainstorming imo. mpv just has a lot of commands and binding even a subset of that to a single set of keys seems difficult. Regarding the current state of key bindings: I'm not too happy with the defaults, hence why my |
Already a feature no? |
Indeed, it looks like it. This is great and probably something the default bindings could benefit from. |
Am I the only one thinking that scroll up & scroll down on a touchpad should respectively raise & lower the volume 🔈 of the playback? And that moving from left to right on the trackpad should scrub through the playback of whatever is being played with mpv? As it currently stands with I am aware these settings can be changed in the Just harping 🎵 on that attention to detail thing. |
FWIW, here are my bindings: https://github.com/FichteFoll/dotfiles/blob/master/mpv/.config/mpv/input.conf
The rest is pretty uninteresting in the general sense and just some personal preferences. |
@FichteFoll thanks for sharing. I saw you remapped the scroll up / down to adjust the volume 👍 However, I didn't see a scroll left / right? I don't use a mouse per se as I am on a portable 💻 so I end up using the trackpad / touchpad 99% of the time, so being able to scrub the playback using two fingers ✌🏾 to the left or to right is crucial for my situation. Thanks again for sharing. cheers 🍻 |
I use this config primarily on my desktop, which has a standard mouse and is not capable of scrolling left and right. I could test if it works for my laptop, but I think I'd end up using the arrow keys to seek anyway. |
I now have my trackpad / touchpad setup to the way that seems sane 👩⚕️ to my liking. I ended up adding the below to my input.conf
Not exactly sure why the |
There was a request over in #5466 for
|
These were removed once. If they're readded, I think they should use more logical keys. |
This adds key bindings for some semi-popular features. It also tries to cleanup some old bindings. For example w/e for panscan is now changed to w/W. In all cases, the old bindings are still kept and work, though. Part of an ongoing attempt to cleanup the default key bindings. See #973 for some context.
This adds key bindings for some semi-popular features. It also tries to cleanup some old bindings. For example w/e for panscan is now changed to w/W. In all cases, the old bindings are still kept and work, though. Part of an ongoing attempt to cleanup the default key bindings. See mpv-player#973 for some context.
I would really like to see mouse side buttons skipping to next/previous chapters with the default bindings. Almost all other media players I've used do this by default or skip to the next file.
|
From #6361: Consider using = instead of (or perhaps in addition to) + in some places to avoid having to shift (e.g. on standard US QWERTY layout) for +. E.g.
|
This should be eventually done. But this time, my opinion is that we shouldn't gratuitously change bindings just because.
There are some things that really should be changed and everyone agrees about, such as remapping
o
.Some suggestions are controversial, like mapping
ESC
to exit fullscreen.Anyway, let the bikeshedding begin.
The text was updated successfully, but these errors were encountered: