ao_pipewire: fix ao-volume

[pkunk]

Store volume only in mpv format, convert it from spa a soon as possible.
Pass volumes to pw_stream_set_control as array.

[pkunk]

@t-8ch can you take a look please.

[t-8ch]

@pkunk What issue does it fix? That should be part of the commit message.

I assume that the call to pw_stream_set_control() is wrong. It should supply an array of floats.
Do we need the other changes?
The argument list should be terminated with a 0, can you add this too?
The same problem also exists in the logic for muting, can you fix that, too?

[pkunk]

Updated the commit message.
Added terminating 0s.
Don't think muting is affected, we pass only one value here for entire stream. Also it works fine for me.
I'm not aware about any other required changes. Maybe 5.1 support will require some.

[t-8ch]

Thanks!

I'm curious about the incorrect scaling. Because this worked for me (and presumably the other testers).
Can you provide steps to reproduce this?
Can you also test if only fixing the calls to pw_stream_set_control() and not shuffling the scaling around works for you?

Muting will also be affected for some users. The trailing 0 is needed for all calls to pw_stream_set_control(). If it's missed, the behavior is system-dependent it seems however.

[pkunk]

Just to be 100% sure. Did you tested ao-volume?
I have non-standard input.conf:

9 add ao-volume -4
/ add ao-volume -4
0 add ao-volume 4
* add ao-volume 4
m cycle ao-mute

Ah yes, I have added 0 to mute too.

[t-8ch]

Yes.

0 add ao-volume 2
9 add ao-volume -2
m cycle ao-mute
p cycle-values ao-volume 25 50 75 100

I can also see the volume in pavucontrol matching exactly the values in mpv.

[pkunk]

Yes, just tested, you right. Seems fix for pw_stream_set_control() is enough.
I'll remove my changes for scaling. I personally still prefer them, but they are not related to the problem.

On unrelated note, just tested 5.1 and ao-volume basically nonfunctional here, just resets everything to 0.

[t-8ch]

Thanks for testing! I don't have anything against the cosmetic changes. It's up to the mpv maintainers. As for 5.1, if you have the setup to test it, any contribution would be appreciated! Feb 5, 2022 12:40:59 Alex B ***@***.***>:

…

Yes, just tested, you right. Seems fix for *pw_stream_set_control()* is enough. I'll remove my changes for scaling. I personally still prefer them, but they are not related to the problem. On unrelated note, just tested 5.1 and ao-volume basically nonfunctional here, just resets everything to 0. — Reply to this email directly, view it on GitHub[#9830 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAFPITJPQ3O4QM5IWLVTLTLUZUEEVANCNFSM5NSZ73VQ]. Triage notifications on the go with GitHub Mobile for iOS[https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android[https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub]. You are receiving this because you were mentioned. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAD8AAAA/CAYAAABXXxDfAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAAmSURBVGiB7cEBDQAAAMKg909tDwcUAAAAAAAAAAAAAAAAAAAAJwY+QwABivJx1AAAAABJRU5ErkJggg==###24x24:true###][Tracking image][https://github.com/notifications/beacon/AAFPITNINRY4UEZL5GV3FJDUZUEEVA5CNFSM5NSZ73V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHVW42PQ.gif]

[t-8ch]

This is now ready to merge from my PoV.

[etircopyh]

LGTM.

[philipl]

Thanks!

[etircopyh]

It seems to break if media file is using more than 2 channels. It can be worked around by passing --audio-channels=stereo.

[etircopyh]

cc @pkunk @t-8ch