Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take topicdata() and formatmap() out of the queue #27

Closed
jpmens opened this issue Feb 20, 2014 · 2 comments
Closed

Take topicdata() and formatmap() out of the queue #27

jpmens opened this issue Feb 20, 2014 · 2 comments

Comments

@jpmens
Copy link
Collaborator

jpmens commented Feb 20, 2014

topic processing and format functions are done in the job queue, i.e. they're invoked N times if a message has N targets.

Pull those up and invoke before the job is added to the queue.

Simultaneously, attempt to parse JSON from payload BEFORE the filter() function is invoked, and pass data{} to it as well. (Doesn't cost more, and adds functionality.) In order to not break existing filter(), add data=None to end of call.

amotl added a commit to daq-tools/mqttwarn that referenced this issue Feb 14, 2016
amotl added a commit to daq-tools/mqttwarn that referenced this issue Feb 14, 2016
…values into topic targets

Improve overall robustness and address mqtt-tools#27
amotl added a commit to daq-tools/mqttwarn that referenced this issue Feb 14, 2016
…values into topic targets

Improve overall robustness and address mqtt-tools#27
amotl added a commit to daq-tools/mqttwarn that referenced this issue Feb 14, 2016
- Interpolate transformation data values into topic targets
- Improve overall robustness and address mqtt-tools#27
@jpmens
Copy link
Collaborator Author

jpmens commented Feb 15, 2016

Addressed in #169

@jpmens jpmens closed this as completed Feb 15, 2016
@amotl
Copy link
Member

amotl commented Feb 15, 2016

The first part "Pull those up and invoke before the job is added to the queue" in fact is addressed and resolved, that's true. Don't know about the "attempt to parse JSON from payload BEFORE the filter() function is invoked, and pass data{} to it as well" part, though, since we're not yet into filtering. Please check.

@jpmens jpmens reopened this Feb 16, 2016
@jpmens jpmens closed this as completed Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants