Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fwknop-2.6.5 with changes from 1ce8004 fails to compile server build with --disable-udp-server #143

Closed
Coacher opened this issue Feb 18, 2015 · 4 comments
Closed

fwknop-2.6.5 with changes from 1ce8004 fails to compile server build with --disable-udp-server #143

Coacher opened this issue Feb 18, 2015 · 4 comments

Comments

@Coacher
Copy link
Contributor

Coacher commented Feb 18, 2015

Hello.

I've tried to build fwknop-2.6.5 server with changes from 1ce8004 and --disable-udp-server option among others, but the build failed. Without this patch fwknop-2.6.5 builds fine with exactly the same suite of build options. Not sure if this change is supposed to work with 2.6.5, but I thought this could a bug, not a feature. See the full build log below. Here are my build options:

--prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu
--mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share
--sysconfdir=/etc --localstatedir=/var/lib --disable-dependency-tracking
--disable-silent-rules --libdir=/usr/lib64
--docdir=/usr/share/doc/fwknop-2.6.5-r9999 --localstatedir=/run
--enable-digest-cache --disable-client --enable-file-cache
--enable-server --disable-udp-server --without-gpgme

OS: Gentoo amd64
If you need additional info, I am ready to provide it for you.
@Coacher
Copy link
Contributor Author

Coacher commented Feb 18, 2015

build.log: https://paste.kde.org/pkaxwobwr

@Coacher Coacher changed the title fwknop-2.6.5 with changes from 1ce8004 breaks server build with --disable-udp-server fwknop-2.6.5 with changes from 1ce8004 fails to compile server build with --disable-udp-server Feb 18, 2015
mrash added a commit that referenced this issue Feb 19, 2015
@mrash
[server] bug fix to exclude pcap.h only in --enable-udp-server mode
bf25103 
This commit fixes issue #143 on github reported by Coacher. The previous
commit introduced a build time error for non UDP server mode as seen
here:

https://paste.kde.org/pkaxwobwr
@mrash
Copy link
Owner

mrash commented Feb 19, 2015

Fixed, thanks.

@mrash mrash closed this as completed Feb 19, 2015
@Coacher
Copy link
Contributor Author

Coacher commented Feb 19, 2015

Thanks! I've tested it out and fwknopd now builds fine both with and without udp-server mode.

@mrash
Copy link
Owner

mrash commented Feb 19, 2015

Great, thanks for letting me know, and for filing the initial bug report.

On Wed, Feb 18, 2015 at 9:17 PM, Coacher notifications@github.com wrote:

Thanks! I've tested it out and fwknopd now builds fine both with and
without udp-server mode.

—
Reply to this email directly or view it on GitHub
#143 (comment).

Michael Rash | Founder
http://www.cipherdyne.org/
Key fingerprint = 53EA 13EA 472E 3771 894F AC69 95D8 5D6B A742 839F

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrash @Coacher