Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

khorben/coverity/1355235 TOCTOU #286

Merged
merged 4 commits into from Aug 29, 2018
Merged

khorben/coverity/1355235 TOCTOU #286

merged 4 commits into from Aug 29, 2018

Commits on Aug 27, 2018

  1. Avoid TOCTOU when calling stat() just before fopen() 

    This is the first part of three for Coverity issue 1355235.
    @khorben
    khorben committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    7eadce3 View commit details
    Browse the repository at this point in the history

  2. Avoid TOCTOU by using fstat() after open() 

    This also needs fileno() after fopen().

This is the second part of three for Coverity issue 1355235.
    @khorben
    khorben committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    cb8632f View commit details
    Browse the repository at this point in the history

  3. Avoid TOCTOU by using fstat() after open() 

    This also needs fileno() after fopen(). This time it addresses the code
for the client.

This is the third part of three for Coverity issue 1355235.
    @khorben
    khorben committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    2def3bb View commit details
    Browse the repository at this point in the history

  4. Look for support for fileno() in the system 

    This should help fwknop remain as portable as before.
The fallback code still suffers from the TOCTOU condition though.
    @khorben
    khorben committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    4066456 View commit details
    Browse the repository at this point in the history