khorben/coverity/1355235 TOCTOU #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first part of three for Coverity issue 1355235.
This also needs fileno() after fopen(). This is the second part of three for Coverity issue 1355235.
This also needs fileno() after fopen(). This time it addresses the code for the client. This is the third part of three for Coverity issue 1355235.
This should help fwknop remain as portable as before. The fallback code still suffers from the TOCTOU condition though.
|
Excellent, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes leverage fstat() to avoid TOCTOU conditions. This also requires fileno() when using fopen(). Judging from the existing code, fileno() may not be available on every platform (like Windows). In this case the fallback code is equivalent to the previous one with the flaw.
Reported in Coverity as issue 1355235.