Merge pull request pytroll#1710 from djhoese/bugfix-nucaps-fill-value

Fix NUCAPS reader having incorrect _FillValue attribute
mraspaud · Jun 2, 2021 · 1289aa3 · 1289aa3
2 parents f4fb747 + e7855b9
commit 1289aa3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/satpy/readers/nucaps.py b/satpy/readers/nucaps.py
@@ -221,6 +221,9 @@ def get_dataset(self, dataset_id, ds_info):
             data = data.where((data <= valid_max))  # | (data >= valid_min))
         if fill_value is not None:
             data = data.where(data != fill_value)
+            # this _FillValue is no longer valid
+            metadata.pop('_FillValue', None)
+            data.attrs.pop('_FillValue', None)
 
         data.attrs.update(metadata)
         # Older format

diff --git a/satpy/tests/reader_tests/test_nucaps.py b/satpy/tests/reader_tests/test_nucaps.py
@@ -249,6 +249,8 @@ def test_load_pressure_based(self):
         for v in datasets.values():
             # self.assertNotEqual(v.info['resolution'], 0)
             self.assertEqual(v.ndim, 2)
+            if np.issubdtype(v.dtype, np.floating):
+                assert '_FillValue' not in v.attrs
 
     def test_load_individual_pressure_levels_true(self):
         """Test loading Temperature with individual pressure datasets."""