Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Readme #66

Closed
2 tasks done
mratsim opened this issue Jun 20, 2020 · 0 comments · Fixed by #69
Closed
2 tasks done

Cleanup Readme #66

mratsim opened this issue Jun 20, 2020 · 0 comments · Fixed by #69
Labels
enhancement :shipit: New feature or request ergonomics 💯 good first issue 🔧 Good for newcomers

Comments

@mratsim
Copy link
Owner

mratsim commented Jun 20, 2020

  • Curve configuration link is wrong
  • License should explain that the library has no dependencies and GNU library like GMP are only used for testing
@mratsim mratsim added enhancement :shipit: New feature or request good first issue 🔧 Good for newcomers ergonomics 💯 labels Jun 20, 2020
mratsim added a commit that referenced this issue Jul 24, 2020
@mratsim mratsim linked a pull request Jul 24, 2020 that will close this issue
mratsim added a commit that referenced this issue Jul 24, 2020
* Proof-of-Concept Assembly code generator

* Tag inline per procedure so we can easily track the tradeoff on tower fields

* Implement Assembly for modular addition (but very curious off-by-one)

* Fix off-by one for moduli with non msb set

* Stash (super fast) alternative but still off by carry

* Fix GCC optimizing ASM away

* Save 1 register to allow compiling for BLS12-381 (in the GMP test)

* The compiler cannot find enough registers if the ASM file is not compiled with -O3

* Add modsub

* Add field negation

* Implement no-carry Assembly optimized field multiplication

* Expose UseX86ASM to the EC benchmark

* omit frame pointer to save registers instead of hardcoding -O3. Also ensure early clobber constraints for Clang

* Prepare for assembly fallback

* Implement fallback for CPU that don't support ADX and BMI2

* Add CPU runtime detection

* Update README closes #66

* Remove commented out code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement :shipit: New feature or request ergonomics 💯 good first issue 🔧 Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant