Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds develop trigger to pkgdown action #108

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Adds develop trigger to pkgdown action #108

merged 2 commits into from
Jul 11, 2024

Conversation

tristan-myles
Copy link
Collaborator

Pull Request

Checklist:

  • I have added new dependencies in DESCRIPTION
  • I have bumped the version number in DESCRIPTION
  • I have updated the NEWS.md
  • I have added unit tests using testthat
  • I have checked that the package can install locally using devtools::install_local("<path-to-epireview>")
  • I have added documentation where required
  • My documentation includes examples of how to use the function
  • If necessary, I have updated priority-pathogens

@tristan-myles
Adds check for develop & updates build condition
5d42b6f 
- GH-pages only builds on a push to main
- Actions runs for a PR & push to develop
@tristan-myles
Removes redundant build trigger on release
03df736
M-Kusumgar
M-Kusumgar approved these changes Jul 11, 2024
View reviewed changes
Copy link

@M-Kusumgar M-Kusumgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CosmoNaught CosmoNaught merged commit ce05c33 into develop Jul 11, 2024
1 check passed
@CosmoNaught CosmoNaught deleted the pkgdown-action-update branch July 11, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plietar plietar plietar approved these changes

@M-Kusumgar M-Kusumgar M-Kusumgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tristan-myles @plietar @M-Kusumgar @CosmoNaught