Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split intermediate data into base and children data #32

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

r-ash
Copy link
Contributor

@r-ash r-ash commented Aug 15, 2023

Fair bit of churn, interesting bit is in types.hpp

@r-ash r-ash requested a review from richfitz August 15, 2023 16:12
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 98.67% and project coverage change: +0.03% 🎉

Comparison is base (745e56a) 97.83% compared to head (f3ed9ae) 97.87%.

❗ Current head f3ed9ae differs from pull request most recent head 4e8947a. Consider uploading reports for the commit 4e8947a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   97.83%   97.87%   +0.03%     
==========================================
  Files          18       18              
  Lines        1064     1080      +16     
==========================================
+ Hits         1041     1057      +16     
  Misses         23       23              
Files Changed Coverage Δ
inst/include/model_simulation.hpp 98.15% <98.21%> (+0.05%) ⬆️
inst/include/general_demographic_projection.hpp 100.00% <100.00%> (ø)
inst/include/hiv_demographic_projection.hpp 100.00% <100.00%> (ø)
inst/include/types.hpp 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@richfitz richfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, churn is at least easy to follow

@richfitz richfitz merged commit a12b0f1 into main Aug 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants