Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mrc-2797 Remove calibration plot when user changes calibration options #630

Merged
merged 5 commits into from Nov 22, 2021

Conversation

LekanAnni
Copy link
Contributor

@LekanAnni LekanAnni commented Nov 19, 2021

Displays calibrate plot only when calibration is complete

Patches

Checklist

  • I have incremented version number, or version needs no increment
  • The build passed successfully, or failed because of ADR tests

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #630 (0b48003) into master (a0e64da) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #630   +/-   ##
=======================================
  Coverage        98%    98%           
  Complexity      281    281           
=======================================
  Files           205    205           
  Lines          5928   5930    +2     
  Branches        818    819    +1     
=======================================
+ Hits           5832   5834    +2     
  Misses           61     61           
  Partials         35     35           
Impacted Files Coverage Δ
...c/app/components/modelCalibrate/ModelCalibrate.vue 100% <100%> (ø)
src/app/static/src/app/hintVersion.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0e64da...0b48003. Read the comment docs.

Copy link
Contributor

@EmmaLRussell EmmaLRussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It just needs to to the same thing for the 'Review results below' label too - since both of these use calibrationPlotGenerated, and nothing else does, it might be worth updating this computed property to check for complete as well.

Copy link
Contributor

@EmmaLRussell EmmaLRussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hillalex hillalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, just need to fix conflicts

@LekanAnni LekanAnni merged commit b2c58f8 into master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants