New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mrc-2797 Remove calibration plot when user changes calibration options #630
Conversation
Codecov Report
@@ Coverage Diff @@
## master #630 +/- ##
=======================================
Coverage 98% 98%
Complexity 281 281
=======================================
Files 205 205
Lines 5928 5930 +2
Branches 818 819 +1
=======================================
+ Hits 5832 5834 +2
Misses 61 61
Partials 35 35
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! It just needs to to the same thing for the 'Review results below' label too - since both of these use calibrationPlotGenerated
, and nothing else does, it might be worth updating this computed property to check for complete
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, just need to fix conflicts
Displays calibrate plot only when calibration is complete
Patches
Checklist