Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure ages from create_survey_dhs are of numeric type #13

Closed
athowes opened this issue Dec 8, 2021 · 0 comments · Fixed by #14
Closed

Ensure ages from create_survey_dhs are of numeric type #13

athowes opened this issue Dec 8, 2021 · 0 comments · Fixed by #14
Assignees
@athowes
Labels
bug Something isn't working

Comments

@athowes
Copy link

athowes commented Dec 8, 2021

The function create_surveys_dhs gives MaxAgeMen columns string type rather than numeric when there are surveys which have empty entries (e.g. men were not surveyed). This can cause issues later on.

iso3 <- "ZWE"
surveys <- create_surveys_dhs(iso3, survey_characteristics = 24)
dplyr::select(surveys, SurveyId, MaxAgeWomen, MaxAgeMen)
@athowes athowes added the bug Something isn't working label Dec 8, 2021
@athowes athowes self-assigned this Dec 8, 2021
jeffeaton added a commit that referenced this issue Dec 8, 2021
@jeffeaton
create test reproduce issue #13
430e3f5
jeffeaton added a commit that referenced this issue Dec 8, 2021
@jeffeaton
address issue #13
def295e
@jeffeaton jeffeaton mentioned this issue Dec 8, 2021
Merged
@athowes athowes mentioned this issue Dec 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athowes athowes

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 13 mrc-ide/naomi.utils
1 participant
@athowes