-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vignette for sircovid #137
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 702 702
=========================================
Hits 702 702
Continue to review full report at Codecov.
|
Improve fitting by - fitting to daily deaths - adjusting C_1 and C_2 to match England population size - plot an example fit so we can see how far off we are
This should be relatively quick to run, but copy of output included here too: |
Would appreciate comment on whether the saveRDS/loadRDS used for the long runs here is viable. Also the longest one is ~80Mb, so whether I should make a greater effort to prune that down (though I'm not immediately sure how) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will arrange some other way of orchestrating the long runs, probably along the lines of redux's offline vignette approach. Once people are happy with the science side I'll look at this, then squash out or filter the large objects
inst/extdata/LICENSE_data.txt
Outdated
Files: | ||
- publishedweek392020.xlsx | ||
- covid19infectionsurveydatasets20200528.xlsx | ||
- covid19infectionsurveydatasets20201009.xlsx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these are publically available, I'd rather explore downloading on demand than including them, as they will be forever out of date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've given links to all of these datasets, both the landing page and the specific version downloaded. I think we should keep these specific versions because the serosurveys are cumulative and don't have the time series (hence the inclusion of two to get timepoints), and because the data used is specific to certain dates, as noted in the vignette. So we don't want to update any of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will arrange some other way of orchestrating the long runs, probably along the lines of redux's offline vignette approach. Once people are happy with the science side I'll look at this, then squash out or filter the large objects
f079342
to
712b3d2
Compare
712b3d2
to
cc5ef80
Compare
Co-authored-by: Rich FitzJohn <rich.fitzjohn@gmail.com>
TODO:
|
Still needed: