Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vignette for sircovid #137

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Add vignette for sircovid #137

wants to merge 31 commits into from

Conversation

johnlees
Copy link
Member

@johnlees johnlees commented Oct 15, 2020

Still needed:

  • Get a decent fit (I think just a problem with the MCMC? Or data and parameter spec?)
  • Check if there is an automated way to look at the user parameters needed for an odin model
  • Add some plots of the results
  • Look at the Rt & plot it
  • Add a section on forecasting

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #137 (d7ce337) into master (07fb467) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #137   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          702       702           
=========================================
  Hits           702       702           
Impacted Files Coverage Δ
R/carehomes.R 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07fb467...d7ce337. Read the comment docs.

@johnlees
Copy link
Member Author

johnlees commented Nov 4, 2020

This should be relatively quick to run, but copy of output included here too:
vignette.zip

@johnlees johnlees marked this pull request as ready for review November 4, 2020 17:56
@johnlees
Copy link
Member Author

johnlees commented Nov 4, 2020

Would appreciate comment on whether the saveRDS/loadRDS used for the long runs here is viable. Also the longest one is ~80Mb, so whether I should make a greater effort to prune that down (though I'm not immediately sure how)

Copy link
Member

@richfitz richfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will arrange some other way of orchestrating the long runs, probably along the lines of redux's offline vignette approach. Once people are happy with the science side I'll look at this, then squash out or filter the large objects

DESCRIPTION Show resolved Hide resolved
R/carehomes.R Show resolved Hide resolved
inst/extdata/LICENSE_data.txt Outdated Show resolved Hide resolved
Files:
- publishedweek392020.xlsx
- covid19infectionsurveydatasets20200528.xlsx
- covid19infectionsurveydatasets20201009.xlsx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these are publically available, I'd rather explore downloading on demand than including them, as they will be forever out of date

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've given links to all of these datasets, both the landing page and the specific version downloaded. I think we should keep these specific versions because the serosurveys are cumulative and don't have the time series (hence the inclusion of two to get timepoints), and because the data used is specific to certain dates, as noted in the vignette. So we don't want to update any of them.

vignettes/ons_deaths.csv Show resolved Hide resolved
vignettes/sircovid-fits.Rmd Show resolved Hide resolved
vignettes/sircovid-fits.Rmd Outdated Show resolved Hide resolved
vignettes/sircovid-fits.Rmd Outdated Show resolved Hide resolved
vignettes/sircovid-fits.Rmd Outdated Show resolved Hide resolved
vignettes/sircovid-fits.Rmd Outdated Show resolved Hide resolved
Copy link
Member

@richfitz richfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will arrange some other way of orchestrating the long runs, probably along the lines of redux's offline vignette approach. Once people are happy with the science side I'll look at this, then squash out or filter the large objects

@johnlees
Copy link
Member Author

johnlees commented Nov 9, 2020

TODO:

  • Update to use coef() (when supported in dust and odin.dust)
  • Fix generation of large objects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants