forked from redhat-plumbers/systemd-rhel8
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
lgtm: replace the query used for looking for fgets with a more genera…
…l query to make it easier to comlain about `strtok` :-) Inspired by systemd/systemd#11963, which, in turn, was prompted by systemd/systemd#11555. (cherry picked from commit 7ba5ded) Related: #2017033
- Loading branch information
Showing
2 changed files
with
30 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
/** | ||
* @name Use of potentially dangerous function | ||
* @description Certain standard library functions are dangerous to call. | ||
* @kind problem | ||
* @problem.severity error | ||
* @precision high | ||
* @id cpp/potentially-dangerous-function | ||
* @tags reliability | ||
* security | ||
* | ||
* Borrowed from | ||
* https://github.com/Semmle/ql/blob/master/cpp/ql/src/Security/CWE/CWE-676/PotentiallyDangerousFunction.ql | ||
*/ | ||
import cpp | ||
|
||
predicate potentiallyDangerousFunction(Function f, string message) { | ||
( | ||
f.getQualifiedName() = "fgets" and | ||
message = "Call to fgets is potentially dangerous. Use read_line() instead." | ||
) or ( | ||
f.getQualifiedName() = "strtok" and | ||
message = "Call to strtok is potentially dangerous. Use extract_first_word() instead." | ||
) | ||
} | ||
|
||
from FunctionCall call, Function target, string message | ||
where | ||
call.getTarget() = target and | ||
potentiallyDangerousFunction(target, message) | ||
select call, message |
This file was deleted.
Oops, something went wrong.