Add missing edges to systemd-analyze dot #11555
Conversation
roberthoffmann
changed the title
There was a problem hiding this comment.
Making this configurable is a bit over-the-top, but the patch looks OK.
Adding analyze.conf just for this would be strange, but I expect we'll want to add more configuration (in particular for systemd-analyze security) so it makes sense to have a configuration file. But I think we should allow the user to create their own configuration, i.e. we should look at paths under ~/.config/systemd/.
keszybz
added
analyze
reviewed/needs-rework 🔨
|
we usually want to merge "perfect" PRs, i.e. PRs where each commit makes logical sense, but not necessarily historical one. i.e. PRs that are perfectly bisectable, where on each commit all test cases pass and that makes sense on its own. Consider using this:
to make sure that your PR remains in fully bisectable state. |
Triggered by systemd#11555
…l query to make it easier to comlain about `strtok` :-) Inspired by systemd#11963, which, in turn, was prompted by systemd#11555.
…l query to make it easier to comlain about `strtok` :-) Inspired by systemd#11963, which, in turn, was prompted by systemd#11555.
roberthoffmann
force-pushed
the
systemd-analyze_add_missing_edges
branch
2 times, most recently
from
e34e073
to
2fdfe97
Compare
| return log_oom(); | ||
| if (r < 0) { | ||
| log_error("Invalid syntax, ignoring: %s", arg_dot_color_style); | ||
| return r; |
There was a problem hiding this comment.
return log_error_errno(r, …
Also, you are not ignoring the error here, don#t say you do
There was a problem hiding this comment.
return and log_error lines still need to be folded into one
Add BindsTo, OnFailure, Triggers. Make colors and styles configurable. Add analyze.conf manpage, /etc/systemd/analyze.conf
Add user configuration, use arrays, add PartOf.
Add options --failure and --triggers to shell completion.
Add option --dependency-color-style
Options dependency-kind, dependency-color, dependency-style, helper function, parsing, etc.
roberthoffmann
force-pushed
the
systemd-analyze_add_missing_edges
branch
from
2fdfe97
to
5c18fd5
Compare
| const char *style, | ||
| char* patterns[], | ||
| char* from_patterns[], | ||
| char* to_patterns[]) { |
There was a problem hiding this comment.
style nit: empty line after open bracket https://github.com/systemd/systemd/blob/master/docs/CODING_STYLE.md
…l query to make it easier to comlain about `strtok` :-) Inspired by systemd/systemd#11963, which, in turn, was prompted by systemd/systemd#11555. (cherry picked from commit 7ba5ded) Related: #2017033
…l query to make it easier to comlain about `strtok` :-) Inspired by systemd/systemd#11963, which, in turn, was prompted by systemd/systemd#11555. (cherry picked from commit 7ba5ded) Related: #2017033
Add BindsTo, OnFailure, Triggers. Make colors and styles
configurable. Add analyze.conf manpage, /etc/systemd/analyze.conf