Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function get_magic_quotes_gpc() is now deprecated in PHP 7.4 #661

Closed
joostdebruijn opened this issue Dec 24, 2019 · 3 comments · Fixed by #665
Closed

Function get_magic_quotes_gpc() is now deprecated in PHP 7.4 #661

joostdebruijn opened this issue Dec 24, 2019 · 3 comments · Fixed by #665

Comments

@joostdebruijn
Copy link

When using this library with PHP 7.4.1:

PHP Deprecated: Function get_magic_quotes_gpc() is deprecated in .../mrclay/minify/lib/HTTP/ConditionalGet.php on line 320
@robbykrlos
Copy link
Contributor

Any plans for this to be fixed? Can I fix it with a PR?

@glensc
Copy link
Collaborator

glensc commented Mar 5, 2020

Only way to find out is to submit the PR

robbykrlos added a commit to robbykrlos/minify that referenced this issue Mar 6, 2020
@robbykrlos
Function get_magic_quotes_gpc() is now deprecated in PHP 7.4 mrclay#661
d9912b3 
- removed deprecated function that since PHP 5.4.0 returns FALSE always, and since PHP 7.4 is deprecated.
@robbykrlos
Copy link
Contributor

robbykrlos commented Mar 6, 2020 •
edited
Loading

Done, PR sent - Function get_magic_quotes_gpc() is now deprecated in PHP 7.4 #661 #665

https://www.php.net/manual/en/function.get-magic-quotes-gpc.php

@robbykrlos robbykrlos mentioned this issue Mar 6, 2020
Merged
glensc pushed a commit that referenced this issue Mar 6, 2020
@robbykrlos @glensc
Function get_magic_quotes_gpc() is now deprecated in PHP 7.4 #661
5705fc9 
- removed deprecated function that since PHP 5.4.0 returns FALSE always, and since PHP 7.4 is deprecated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Function get_magic_quotes_gpc() is now deprecated in PHP 7.4 robbykrlos/minify
3 participants
@glensc @joostdebruijn @robbykrlos