Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests that should be passing are marked TODO #12714

Closed
donmccurdy opened this issue Nov 21, 2017 · 1 comment · Fixed by #12768
Closed

Tests that should be passing are marked TODO #12714

donmccurdy opened this issue Nov 21, 2017 · 1 comment · Fixed by #12768

Comments

@donmccurdy
Copy link
Collaborator

Opening the tests now, I see:

1789 tests completed in 6063 milliseconds, with 590 failed, 0 skipped, and 1196 todo.
7647 assertions of 8916 passed, 1269 failed.

A lot of those "failures" are weird errors like this:

Source: at Object.QUnit.module.todo (http://localhost:8080/test/unit/three.source.unit.js:2788:9) at processModule (http://localhost:8080/node_modules/qunitjs/qunit/qunit.js:2733:16) at Function.module$1.todo (http://localhost:8080/node_modules/qunitjs/qunit/qunit.js:2797:4) at Object.QUnit.module (http://localhost:8080/test/unit/three.source.unit.js:2760:15) at processModule (http://localhost:8080/node_modules/qunitjs/qunit/qunit.js:2733:16) at Object.module$1 [as module] (http://localhost:8080/node_modules/qunitjs/qunit/qunit.js:2754:4) at http://localhost:8080/test/unit/three.source.unit.js:7:8

I only checked a few but I think those are happening because they are "passing" tests in a module that is marked as TODO. PropertyBinding.test.js and BufferGeometry.test.js are good examples of this. So in some previous change, a bunch of TODO test modules were added, and passing tests were accidentally included?

I'm also wondering about all the TODOs... we probably don't want unit tests on private methods, so maybe TODOs like AnimationAction._updateTimeScale can be removed.

@Itee thanks for the refactoring and ES6 modules stuff! Any ideas on this?

@donmccurdy
Copy link
Collaborator Author

I guess that individual tests should be marked as QUnit.todo, rather than entire modules?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant