Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wireframe example broken #6431

Closed
brason opened this issue Apr 19, 2015 · 7 comments
Closed

Wireframe example broken #6431

brason opened this issue Apr 19, 2015 · 7 comments
Labels

Comments

@brason
Copy link
Contributor

brason commented Apr 19, 2015

I noticed that the webgl_materials_wireframe example doesn't show correctly anymore. Just wanted to give a heads up.

wireframe

@Wizarth
Copy link

Wizarth commented Apr 20, 2015

Wireframe mode on Three.Mesh (with BufferGeometry with unindexed position buffer) is broken for me. It looks like the wireframe mode connects every vertex in order in the position buffer, versus connecting 3, then 3, then 3 (etc) to do triangles.

I'm using release 70, for reference. This used to work in release 63.

@Wizarth
Copy link

Wizarth commented Apr 20, 2015

At some point, the geometry for doing a wireframe changed from tri's (three points making a triangle) to edges (two points, defining an edge). See WireframeHelper for constructing this data structure.

@mrdoob mrdoob added the Bug label Apr 20, 2015
@mrdoob
Copy link
Owner

mrdoob commented Apr 20, 2015

It still looks ok here...? http://threejs.org/examples/index.html#webgl_materials_wireframe

You mean on the dev branch? If so, yes... stuff is broken over there at the moment.

@mrdoob
Copy link
Owner

mrdoob commented Apr 20, 2015

I'm using release 70, for reference. This used to work in release 63.

BufferGeometry and wireframe has never worked 😉

@mrdoob
Copy link
Owner

mrdoob commented Aug 18, 2015

Fixed! 0048009 Even with BufferGeometry 😊

@mrdoob mrdoob closed this as completed Aug 18, 2015
@Wizarth
Copy link

Wizarth commented Aug 18, 2015

Thank you, I expect I'll use this in the near future.

@brason
Copy link
Contributor Author

brason commented Aug 18, 2015

Hooray! Great job :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants