Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I don't think CanvasRenderer works with v71 #6780

Closed
larspetrus opened this issue Jul 3, 2015 · 3 comments
Closed

I don't think CanvasRenderer works with v71 #6780

larspetrus opened this issue Jul 3, 2015 · 3 comments

Comments

@larspetrus
Copy link

It fails on line 84:

_v5 = new THREE.RenderableVertex(),

According to Github search, RenderableVertex is mentioned in 3 files, but not defined anywhere in the repository.
@dubejf
Copy link
Contributor

dubejf commented Jul 3, 2015

Take a look at the examples: http://threejs.org/examples/#canvas_geometry_cube

THREE.RenderableVertex is defined at the beginning of three.js/examples/js/renderers/Projector.js. You probably didn't notice it in GitHub abridged search results.

@larspetrus
Copy link
Author

  1. It works!
  2. I'm disappointed in Github search!
  3. I might submit a PR improving the documentation for using CanvasRenderer.
  4. Thanks!

@dubejf dubejf closed this as completed Jul 3, 2015
@dubejf
Copy link
Contributor

dubejf commented Jul 3, 2015

Thanks @larspetrus, that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@larspetrus @dubejf