add offset to Matrix4.fromArray for consistency with all other fromArray functions #9611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions in the ThreeJS math library.
|
Nice! Do you mind updating the docs, too, when you get a chance? |
|
Thanks! |
aardgoose
pushed a commit
to aardgoose/three.js
that referenced
this pull request
Oct 7, 2016
…ray functions (mrdoob#9611) * add offset to fromArray for consistency with all other fromArray functions in the ThreeJS math library. * Added matrix3/fixed whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed here at Exocortex/Clara.io that the Matrix4 fromArray function didn't allow one to specify offsets. This is very useful functionality when Matrix4s are packed into an ArrayBuffer for things like transfering of bone data from a binary file format.