Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The logic behind preventing multiple form parameters with same name. #67

Closed
oguzhantopcu opened this issue Mar 24, 2018 · 5 comments
Closed

Comments

@oguzhantopcu
Copy link

oauth/oauth.go

Line 835 in 78d6446

return nil, fmt.Errorf("Must have exactly one value per param")

I am creating an application that makes authorized request to following endpoint.
https://www.etsy.com/developers/documentation/reference/listinginventory

The endpoint expects multiple price_on_property field as form parameter. The library blocking this usage type. It blocks my project at the same time :). If there is no plausible reason to prevent this better to make pull request to change the behaviour.

@mrjones
Copy link
Owner

mrjones commented Apr 10, 2018

Indeed, you're right!

http://oauth.net/core/1.0a/#anchor13 says:

Parameters are sorted by name, using lexicographical byte value ordering. If two or more parameters share the same name, they are sorted by their value.

So we should support multiple parameters with the same name.

I'm busy with a new baby, and can't promise to implement this right away. I'll try to make some time for it, but, feel free to send a PR if you need it sooner.

@ccqpein
Copy link
Contributor

ccqpein commented Jun 20, 2019

Hi guys, I am trying to fix this issue today. I give a PR #71 . Please check it out.

@mrjones
Copy link
Owner

mrjones commented Jun 23, 2019

Thanks @ccqpein for taking care of this!

I'm going to mark this fixed, please let me know if anyone has trouble.

@mrjones mrjones closed this as completed Jun 23, 2019
@ccqpein
Copy link
Contributor

ccqpein commented Jun 23, 2019

I hope I don't make some bugs inside.

@raymond-chia
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants