-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The logic behind preventing multiple form parameters with same name. #67
Comments
Indeed, you're right! http://oauth.net/core/1.0a/#anchor13 says:
So we should support multiple parameters with the same name. I'm busy with a new baby, and can't promise to implement this right away. I'll try to make some time for it, but, feel free to send a PR if you need it sooner. |
Hi guys, I am trying to fix this issue today. I give a PR #71 . Please check it out. |
Thanks @ccqpein for taking care of this! I'm going to mark this fixed, please let me know if anyone has trouble. |
I hope I don't make some bugs inside. |
https://github.com/mrjones/oauth/blob/master/oauth.go#L645
It seems like the parameters are not sorted by values |
oauth/oauth.go
Line 835 in 78d6446
I am creating an application that makes authorized request to following endpoint.
https://www.etsy.com/developers/documentation/reference/listinginventory
The endpoint expects multiple price_on_property field as form parameter. The library blocking this usage type. It blocks my project at the same time :). If there is no plausible reason to prevent this better to make pull request to change the behaviour.
The text was updated successfully, but these errors were encountered: