Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scratchpad): Treat boolean false as a valid return value #421

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

mrjones2014
Copy link
Owner

Resolves: #420

How to Test

  1. Type return false in scratchpad
  2. Eval lua
  3. Should show returned boolean instead of saying "no return value"

Testing for Regressions

I have tested the following:

  • Triggering keymaps from legendary.nvim in all modes (normal, insert, visual)
  • Creating keymaps via legendary.nvim, then triggering via the keymap in all modes (normal, insert, visual)
  • Triggering commands from legendary.nvim in all modes (normal, insert, visual)
  • Creating commands via legendary.nvim, then running the command manually from the command line
  • augroup/autocmds created through legendary.nvim work correctly

@mrjones2014 mrjones2014 merged commit 234e2ef into master Oct 23, 2023
2 checks passed
@mrjones2014 mrjones2014 deleted the mrj/420/lua-eval branch October 23, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Lua evaluation fails to show return value if value is boolean false
1 participant