Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Apply itemgroup filter correctly #436

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

mrjones2014
Copy link
Owner

Resolves: #435

How to Test

  1. Have an item group
  2. Trigger the API via require('legendary').find({ itemgroup = "my group" })
  3. It should start the finder with items from the group

Testing for Regressions

I have tested the following:

  • Triggering keymaps from legendary.nvim in all modes (normal, insert, visual)
  • Creating keymaps via legendary.nvim, then triggering via the keymap in all modes (normal, insert, visual)
  • Triggering commands from legendary.nvim in all modes (normal, insert, visual)
  • Creating commands via legendary.nvim, then running the command manually from the command line
  • augroup/autocmds created through legendary.nvim work correctly

@mrjones2014 mrjones2014 merged commit ad4b0ad into master Mar 19, 2024
2 checks passed
@mrjones2014 mrjones2014 deleted the mrj/435/itemlist-filter branch March 19, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: itemgroup filter seems broken.
1 participant