fix: Respect hidden statusline in window size calculation #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The window_height calculation hardcoded subtracting 1 for the height of the statusline. But this is not correct, if the statusline is not visible, which is the case if either the user sets laststatus=0 or sets laststatus=1 and has more than one window open. Fix this by respecting the laststatus setting and adapt the calculation accordingly. This is pretty much identical to the tabline height calculation code that already existed below.
vimpostor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the size calculation hardcoded subtracting 1 for the statusline.
But this is not correct, if the user sets
laststatus=0for example.Fix this by respecting the
laststatussetting in the size calculation.This problem was found in vimpostor/vim-tpipeline#55