fix(mux): fix edge pane detection logic for tmux (#118) #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freddiehaddad
changed the title
mrjones2014
changed the title
mrjones2014
requested changes
Oct 10, 2023
|
Wow, this seems much simpler! Thanks for the PR! I'll wait for @icyrainz to confirm this fixes the issue for him as well before merging. |
|
We're also getting |
Rather than using the format flag (-F) to find all panes and attempting to detect whether or not the active pane is at an edge, the filter flag (-f) can be used instead to conditionally query a single result indicating if the active pane is at an edge.
mrjones2014
approved these changes
Oct 10, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118