New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: never wrap unless at_edge is set to wrap #171

Merged

mrjones2014 merged 1 commit into mrjones2014:master from thenbe:dont-wrap

Mar 28, 2024

Contributor

thenbe commented Mar 27, 2024

fixes #170

In the future, there might room for further refactoring by collapsing the two consecutive if statements.

-  if multiplexer_moved or not will_wrap then
+  if multiplexer_moved or at_edge ~= AtEdgeBehavior.wrap then
     return multiplexer_moved
   end

This would also mean that will_wrap no longer needs to be passed to this function in the first place.


          fix: don't wrap if at_edge is not set to wrap

c997eee

mrjones2014 approved these changes

View reviewed changes

mrjones2014 merged commit a0d40cb into mrjones2014:master

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment