-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for bevy ecs v2 #31
Conversation
Unfortunately, there seems to be an issue and some of the examples aren't working properly at the moment. I tested all the others and they seem fine. sprite - not ok, nothing displayed |
Won't be able to work on this today, but I tried rebasing against the dev branch (locally) and this didn't seem to help the situation. But the rebase was very painless. Should this be pointed at that branch? |
Didn't get anywhere this morning, but observed that the |
It looks like I had just falsely remembered the sprite flipping PR getting merged after ecs v2. Ignoring that would certainly cause issues with sprites showing up. Investigating. edit: yup, that's the issue. Will fully implement sprite flipping in a bit. |
This is now rebased against/pointing at the dev branch. |
Pinging you to let you know that I will likely need to abandon this work for now due to time constraints. I've pushed my current efforts to get this working with bevy's new PBR stuff. This puts this PR in a state where 2d stuff seems to work, but basically everything 3d is broken. It's broken in a way that shaders compile, there are no error messages or warnings, but we just get a grey screen. I suspect that there's something flying over my head related to texture samplers, or perhaps the camera bindings. |
The issue seems related to camera bindings, or bindings in general. I accidentally found that a simple change in if name == "CameraPosition" {
continue;
} |
updates and fixes for 3d and PBR
This is now working (thanks mockersf) but relies on bevyengine/bevy#1798 |
There are some lingering questions about whether the manual |
A work in progress.Things seem to work, but I ran out of time and only fixed one of the examples for now.Should be able to finish this up later tonight.This should be good to go.