Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump winit to v0.25 #41

Merged
merged 1 commit into from
Jun 5, 2021
Merged

Bump winit to v0.25 #41

merged 1 commit into from
Jun 5, 2021

Conversation

gcoakes
Copy link
Contributor

@gcoakes gcoakes commented May 16, 2021

winit v0.25 includes support for propagating mouse motion events in the HTML canvas to the winit window.

I've submitted a similar patch to bevy_winit. The versions will be out of sync, if both repositories don't update before the next release.

@billyb2
Copy link
Contributor

billyb2 commented Jun 2, 2021

Hey @mrk-its, would you mind merging this?

@allsey87
Copy link

allsey87 commented Jun 4, 2021

@billyb2 was the following change necessary for compilation on your end? If so, perhaps this should be included in the PR.

diff --git a/src/lib.rs b/src/lib.rs
index 67ab6b1..c7d26a2 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -140,7 +140,7 @@ pub fn webgl2_handle_window_created_events_system() -> impl FnMut(&mut World) {
                 let winit_windows = world.get_resource::<bevy::winit::WinitWindows>().unwrap();
                 let winit_window = winit_windows.get_window(window_id).unwrap();
                 let mut render_resource_context = WebGL2RenderResourceContext::new(device.clone());
-                render_resource_context.initialize(&winit_window);
+                render_resource_context.initialize(winit_window);
                 render_resource_context
             };
             world.insert_resource::<Box<dyn RenderResourceContext>>(Box::new(

@mrk-its mrk-its merged commit 4ee792d into mrk-its:master Jun 5, 2021
@mrk-its
Copy link
Owner

mrk-its commented Jun 5, 2021

Sorry for delay. Thanks!

@mrk-its mrk-its mentioned this pull request Jun 5, 2021
@billyb2
Copy link
Contributor

billyb2 commented Jun 5, 2021

Sorry for delay. Thanks!

No problem, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants