Update CP437.hs #11
Closed
Update CP437.hs #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One is supposed to accumulate a builder with a right fold. https://www.reddit.com/r/haskell/comments/35udfy/fixing_an_aeson_performance_bug_sometimes_the_old/cr94pdj I skipped that with this attempt, which unfolds the text directly. It seems 10 or more times as fast if I send /usr/share/dict/words through it. `unfoldr` is a pretty strong function with text since it is basically just replicates to the stream representation. But maybe there is something better.
|
Great catch. Please squash the commits together and we will be ready to merge. |
|
Sorry I think I didn't understand that I was making an independent patch-2 via the github interface. I take it the other pull request layers them correctly. |
|
I just asked you to make one single commit form the two. Nevermind, I will squash them and apply from this PR myself. The second PR is of no use (it's identical anyway) — so I'm closing it. |
|
Oh thanks! What I did via the github interface ended up being more complex than what I would have done otherwise, which itself involves a rather narrow supply of git skills. |
|
Applied as c108d12. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One is supposed to accumulate a builder with a right fold. https://www.reddit.com/r/haskell/comments/35udfy/fixing_an_aeson_performance_bug_sometimes_the_old/cr94pdj
I skipped that with this attempt, which unfolds the text directly. It seems 10 or more times as fast if I send /usr/share/dict/words through it.
unfoldris a pretty strong function with text since it is basically just replicates the stream representation. But maybe there is something better.