-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gotestcover is deprecated #45
Comments
@pierrre Thanks for the heads up. I have to apply this to https://github.com/elastic/beats |
@ruflin Are you OK with my new script? It does exactly the same thing. |
@pierrre Will test it in the next hours / days as soon as I get the time for it. |
@pierrre Only did a very brief test and got the error: `cannot use test profile flag with multiple packages`` Our code looks as following:
I assume the package list is the problem. No sure if I should put this in case of |
@ruflin have you read the new script that replaces gotestcover? https://github.com/pierrre/gotestcover#deprecated
|
I wanted to paste the modified line of course that I tried out...
|
I use it in my project: https://github.com/pierrre/imageserver/blob/master/.travis.yml#L24 |
OK I understand.
Yes, try that |
Please try
|
Looks like this gets the job done. Thanks. Now I need to find a way how to make this line shorter / less complex again as we have it multiple times: https://github.com/elastic/beats/blob/master/libbeat/scripts/Makefile#L124 |
You could paste this script in a bash file and run it each time you need it. In my projects, I've copied/pasted this small script :) |
I'm sorry if this deprecation notice is too abrupt for you. (FYI I love Go and I hate bash scripts) |
@pierrre No worries, I really appreciate that you actively inform that the project will not be maintained anymore in the future and even provide a replacement script. The script will work quite well in our Makefiles, no worries. I don't have it on top of my priority list as gotestcover works and I assume the repo will stay around a little bit. |
Don't be afraid, I will not remove the repository :) |
Please read https://github.com/pierrre/gotestcover#deprecated
The text was updated successfully, but these errors were encountered: