Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Travis/Molecule testing #24

Closed
mrlesmithjr opened this issue Aug 1, 2019 · 4 comments
Closed

Integrate Travis/Molecule testing #24

mrlesmithjr opened this issue Aug 1, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@mrlesmithjr
Copy link
Owner

As part of furthering this project, the time has come for us to integrate some valid testing. Initially we may just focus on linting, etc. until we can figure out some valid testing that we can leverage Travis/Molecule for.

@mrlesmithjr mrlesmithjr added the enhancement New feature or request label Aug 1, 2019
nertwork added a commit that referenced this issue Aug 1, 2019
@mrlesmithjr
Copy link
Owner Author

Lot's of issues starting to uncover themselves, which is good. So we can get this stuff cleaned up.

@mrlesmithjr
Copy link
Owner Author

▶ molecule test
--> Validating schema /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/molecule/default/molecule.yml.
Validation completed successfully.
--> Test matrix

└── default
    ├── lint
    ├── cleanup
    ├── destroy
    ├── dependency
    ├── syntax
    ├── create
    ├── prepare
    ├── converge
    ├── idempotence
    ├── side_effect
    ├── verify
    ├── cleanup
    └── destroy

--> Scenario: 'default'
--> Action: 'lint'
--> Executing Yamllint on files found in /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/...
    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/vars/main.yml
      2:28      error    no new line character at the end of file  (new-line-at-end-of-file)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/tasks/monitor.yml
      46:3      error    wrong indentation: expected 4 but found 2  (indentation)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/bootstrap.yml
      39:1      warning  comment not indented like content  (comments-indentation)
      47:1      warning  comment not indented like content  (comments-indentation)
      139:1     warning  comment not indented like content  (comments-indentation)
      163:1     warning  comment not indented like content  (comments-indentation)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/playbook.yml
      17:8      error    wrong indentation: expected 8 but found 7  (indentation)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/group_vars/all/telegraf.yml
      28:5      warning  comment not indented like content  (comments-indentation)
      163:7     warning  comment not indented like content  (comments-indentation)
      201:6     warning  missing starting space in comment  (comments)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/roles/ansible-telegraf/.travis.yml
      12:5      error    wrong indentation: expected 6 but found 4  (indentation)
      29:61     error    no new line character at the end of file  (new-line-at-end-of-file)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/roles/ansible-telegraf/meta/main.yml
      1:1       warning  missing document start "---"  (document-start)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/roles/ansible-telegraf/defaults/main.yml
      75:5      warning  comment not indented like content  (comments-indentation)
      204:7     warning  comment not indented like content  (comments-indentation)
      242:6     warning  missing starting space in comment  (comments)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/roles/ansible-grafana/.travis.yml
      12:5      error    wrong indentation: expected 6 but found 4  (indentation)
      29:61     error    no new line character at the end of file  (new-line-at-end-of-file)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/roles/ansible-grafana/tasks/redhat.yml
      2:1       error    too many blank lines (1 > 0)  (empty-lines)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/roles/ansible-grafana/meta/main.yml
      5:4       warning  missing starting space in comment  (comments)
      21:4      warning  missing starting space in comment  (comments)
      27:4      warning  missing starting space in comment  (comments)
      31:4      warning  missing starting space in comment  (comments)
      41:4      warning  missing starting space in comment  (comments)
      45:4      warning  missing starting space in comment  (comments)
      49:4      warning  missing starting space in comment  (comments)
      57:4      warning  missing starting space in comment  (comments)
      62:4      warning  missing starting space in comment  (comments)
      66:4      warning  missing starting space in comment  (comments)
      78:3      error    wrong indentation: expected 4 but found 2  (indentation)
      80:3      warning  comment not indented like content  (comments-indentation)
      89:5      error    wrong indentation: expected 6 but found 4  (indentation)
      93:4      warning  missing starting space in comment  (comments)
      102:4     warning  missing starting space in comment  (comments)
      108:3     warning  comment not indented like content  (comments-indentation)
      110:5     error    wrong indentation: expected 6 but found 4  (indentation)
      119:4     warning  missing starting space in comment  (comments)
      120:4     warning  missing starting space in comment  (comments)
      121:4     warning  missing starting space in comment  (comments)
      122:4     warning  missing starting space in comment  (comments)
      123:4     warning  missing starting space in comment  (comments)
      124:4     warning  missing starting space in comment  (comments)
      125:4     warning  missing starting space in comment  (comments)
      126:4     warning  missing starting space in comment  (comments)
      127:4     warning  missing starting space in comment  (comments)
      128:3     error    wrong indentation: expected 4 but found 2  (indentation)
      129:4     warning  missing starting space in comment  (comments)
      130:4     warning  missing starting space in comment  (comments)
      132:4     warning  missing starting space in comment  (comments)
      134:3     warning  comment not indented like content  (comments-indentation)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/roles/ansible-chronograf/vars/main.yml
      2:35      error    no new line character at the end of file  (new-line-at-end-of-file)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/roles/ansible-chronograf/meta/main.yml
      1:1       warning  missing document start "---"  (document-start)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/roles/ansible-chronograf/handlers/main.yml
      2:39      error    no new line character at the end of file  (new-line-at-end-of-file)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/roles/ansible-influxdb/.travis.yml
      12:5      error    wrong indentation: expected 6 but found 4  (indentation)
      29:61     error    no new line character at the end of file  (new-line-at-end-of-file)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/roles/ansible-influxdb/meta/main.yml
      1:1       warning  missing document start "---"  (document-start)
      9:3       error    wrong indentation: expected 4 but found 2  (indentation)
      11:5      error    wrong indentation: expected 6 but found 4  (indentation)
      16:5      error    wrong indentation: expected 6 but found 4  (indentation)
      19:5      error    wrong indentation: expected 6 but found 4  (indentation)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/roles/ansible-influxdb/defaults/main.yml
      113:2     warning  comment not indented like content  (comments-indentation)
      117:2     warning  comment not indented like content  (comments-indentation)
      140:4     warning  missing starting space in comment  (comments)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/roles/ansible-docker/.travis.yml
      12:5      error    wrong indentation: expected 6 but found 4  (indentation)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/roles/ansible-docker/meta/main.yml
      10:3      error    wrong indentation: expected 4 but found 2  (indentation)
      12:5      error    wrong indentation: expected 6 but found 4  (indentation)
      15:5      error    wrong indentation: expected 6 but found 4  (indentation)
      21:5      error    wrong indentation: expected 6 but found 4  (indentation)
      25:3      error    wrong indentation: expected 4 but found 2  (indentation)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/roles/ansible-docker/defaults/main.yml
      31:3      warning  comment not indented like content  (comments-indentation)
      52:1      warning  comment not indented like content  (comments-indentation)
      56:1      warning  comment not indented like content  (comments-indentation)
      58:1      warning  comment not indented like content  (comments-indentation)
      60:1      warning  comment not indented like content  (comments-indentation)
      62:1      warning  comment not indented like content  (comments-indentation)
      64:1      warning  comment not indented like content  (comments-indentation)
      66:1      warning  comment not indented like content  (comments-indentation)
      69:1      warning  comment not indented like content  (comments-indentation)
      73:1      warning  comment not indented like content  (comments-indentation)
      77:1      warning  comment not indented like content  (comments-indentation)
      80:1      warning  comment not indented like content  (comments-indentation)
      82:1      warning  comment not indented like content  (comments-indentation)
      84:1      warning  comment not indented like content  (comments-indentation)
      86:1      warning  comment not indented like content  (comments-indentation)
      88:1      warning  comment not indented like content  (comments-indentation)
      92:1      warning  comment not indented like content  (comments-indentation)
      95:1      warning  comment not indented like content  (comments-indentation)
      100:1     warning  comment not indented like content  (comments-indentation)
      108:1     warning  comment not indented like content  (comments-indentation)
      119:1     warning  comment not indented like content  (comments-indentation)
      129:1     warning  comment not indented like content  (comments-indentation)
      131:1     warning  comment not indented like content  (comments-indentation)
      133:1     warning  comment not indented like content  (comments-indentation)
      135:1     warning  comment not indented like content  (comments-indentation)
      137:1     warning  comment not indented like content  (comments-indentation)
      139:1     warning  comment not indented like content  (comments-indentation)
      142:1     warning  comment not indented like content  (comments-indentation)
      145:3     warning  comment not indented like content  (comments-indentation)
      169:3     warning  comment not indented like content  (comments-indentation)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/host_vars/spine2.yml
      1:1       warning  missing document start "---"  (document-start)
      33:9      warning  comment not indented like content  (comments-indentation)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/host_vars/compute2.yml
      1:1       warning  missing document start "---"  (document-start)
      23:9      warning  comment not indented like content  (comments-indentation)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/host_vars/spine1.yml
      1:1       warning  missing document start "---"  (document-start)
      33:9      warning  comment not indented like content  (comments-indentation)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/host_vars/compute1.yml
      1:1       warning  missing document start "---"  (document-start)
      23:9      warning  comment not indented like content  (comments-indentation)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/host_vars/leaf1.yml
      1:1       warning  missing document start "---"  (document-start)
      28:9      warning  comment not indented like content  (comments-indentation)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/host_vars/leaf2.yml
      1:1       warning  missing document start "---"  (document-start)
      28:9      warning  comment not indented like content  (comments-indentation)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/host_vars/leaf3.yml
      1:1       warning  missing document start "---"  (document-start)
      28:9      warning  comment not indented like content  (comments-indentation)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/host_vars/monitoring.yml
      1:1       warning  missing document start "---"  (document-start)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/Vagrant/host_vars/leaf4.yml
      1:1       warning  missing document start "---"  (document-start)
      28:9      warning  comment not indented like content  (comments-indentation)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/meta/main.yml
      1:1       warning  missing document start "---"  (document-start)

    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/defaults/main.yml
      16:3      warning  comment not indented like content  (comments-indentation)
      47:3      warning  comment not indented like content  (comments-indentation)
      64:3      warning  comment not indented like content  (comments-indentation)
      87:3      warning  comment not indented like content  (comments-indentation)

An error occurred during the test sequence action: 'lint'. Cleaning up.
--> Scenario: 'default'
--> Action: 'destroy'

    PLAY [Destroy] *****************************************************************

    TASK [Destroy molecule instance(s)] ********************************************
    changed: [localhost] => (item=None)
    changed: [localhost]

    TASK [Wait for instance(s) deletion to complete] *******************************
    ok: [localhost] => (item=None)
    ok: [localhost]

    TASK [Delete docker network(s)] ************************************************

    PLAY RECAP *********************************************************************
    localhost                  : ok=2    changed=1    unreachable=0    failed=0    skipped=1    rescued=0    ignored=0


(default-python-3)

@mrlesmithjr
Copy link
Owner Author

Skipping, prepare playbook not configured.
--> Scenario: 'default'
--> Action: 'converge'

    PLAY [Converge] ****************************************************************

    TASK [Gathering Facts] *********************************************************
    ok: [ubuntu1804]

    TASK [ansible-frr : include_tasks] *********************************************
    included: /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/tasks/debian.yml for ubuntu1804

    TASK [ansible-frr : debian | Installing Pre-Reqs non-ubuntu] *******************
    skipping: [ubuntu1804]

    TASK [ansible-frr : debian | Installing Pre-Reqs Ubuntu 18+] *******************
 [WARNING]: Could not find aptitude. Using apt-get instead

    ok: [ubuntu1804]

    TASK [ansible-frr : set url on frr between version 4 and 6.0.0] ****************
    skipping: [ubuntu1804]

    TASK [ansible-frr : set url on frr greater than version 6.0.0] *****************
    ok: [ubuntu1804]

    TASK [ansible-frr : debian | Installing FRR 6.0.2] *****************************
    skipping: [ubuntu1804]

    TASK [ansible-frr : debian | Add FRR 6.0.2 (Arm)] ******************************
    skipping: [ubuntu1804]

    TASK [ansible-frr : Ubuntu | Add FRR 6.0.2] ************************************
    ok: [ubuntu1804]

    TASK [ansible-frr : Ubuntu | Add FRR 6.0.2 (Arm)] ******************************
    skipping: [ubuntu1804]

    TASK [ansible-frr : add python frr tools to install list] **********************
    skipping: [ubuntu1804]

    TASK [ansible-frr : add python frr tools to install list] **********************
    skipping: [ubuntu1804]

    TASK [ansible-frr : Install python-ipaddr] *************************************
    ok: [ubuntu1804]

    TASK [ansible-frr : Remove Quagga] *********************************************
    ok: [ubuntu1804]

    TASK [ansible-frr : Fetch FRR version] *****************************************
    ok: [ubuntu1804]

    TASK [ansible-frr : Create our download directory] *****************************
    ok: [ubuntu1804]

    TASK [ansible-frr : Download FRR package] **************************************
    ok: [ubuntu1804] => (item=https://github.com/FRRouting/frr/releases/download/frr-6.0.2/frr_6.0.2-0.ubuntu18.04.1_amd64.deb)

    TASK [ansible-frr : Installing FRR 6.0.2 and netplan apply to fix connectivity] ***
    skipping: [ubuntu1804]

    TASK [ansible-frr : Installing FRR 6.0.2] **************************************
    skipping: [ubuntu1804] => (item=https://github.com/FRRouting/frr/releases/download/frr-6.0.2/frr_6.0.2-0.ubuntu18.04.1_amd64.deb)

    TASK [ansible-frr : stat config] ***********************************************
    ok: [ubuntu1804]

    TASK [ansible-frr : Backup old /etc/frr/daemons.conf and /etc/default/frr] *****
    skipping: [ubuntu1804] => (item=/etc/frr/daemons.conf)
    skipping: [ubuntu1804] => (item=/etc/default/frr)

    TASK [ansible-frr : Remove old /etc/frr/daemons.conf and /etc/default/frr] *****
    ok: [ubuntu1804] => (item=/etc/frr/daemons.conf)
    ok: [ubuntu1804] => (item=/etc/default/frr)

    TASK [ansible-frr : include_tasks] *********************************************
    skipping: [ubuntu1804]

    TASK [ansible-frr : include_tasks] *********************************************
    included: /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/tasks/system_tuning.yml for ubuntu1804

    TASK [ansible-frr : system_tuning | Managing Forwarding] ***********************
    ok: [ubuntu1804] => (item=net.ipv4.ip_forward)
    ok: [ubuntu1804] => (item=net.ipv6.conf.all.forwarding)
 [WARNING]: The value 1 (type int) in a string field was converted to u'1'
(type string). If this does not look like what you expect, quote the entire
value to ensure it does not change.


    TASK [ansible-frr : include_tasks] *********************************************
    included: /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/tasks/config.yml for ubuntu1804

    TASK [ansible-frr : config | Configuring daemons] ******************************
    ok: [ubuntu1804]

    TASK [ansible-frr : config | Configuring debian.conf] **************************
    ok: [ubuntu1804]

    TASK [ansible-frr : config | Configuring zebra.conf] ***************************
    ok: [ubuntu1804]
 [WARNING]: flush_handlers task does not support when conditional


    TASK [ansible-frr : config | Rediscovering Facts] ******************************
    skipping: [ubuntu1804]

    TASK [ansible-frr : config | Configuring FRR] **********************************
    ok: [ubuntu1804]

    TASK [ansible-frr : include_tasks] *********************************************
    included: /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/tasks/monitor.yml for ubuntu1804

    TASK [ansible-frr : monitor | Ensuring /opt/frr/monitoring exists] *************
    ok: [ubuntu1804]

    TASK [ansible-frr : monitor | Capturing sudo Path] *****************************
    ok: [ubuntu1804]

    TASK [ansible-frr : monitor | Capturing vtysh Path] ****************************
    ok: [ubuntu1804]

    TASK [ansible-frr : monitor | Copying Monitoring Scripts] **********************
    ok: [ubuntu1804] => (item=bgp_neighbor_data.py)
    ok: [ubuntu1804] => (item=output_module.py)

    TASK [ansible-frr : monitor | Checking If FRR Service Is Running] **************
    ok: [ubuntu1804]

    TASK [ansible-frr : monitor | Capturing BGP Peers] *****************************
    skipping: [ubuntu1804]

    TASK [ansible-frr : debug] *****************************************************
    fatal: [ubuntu1804]: FAILED! => {"msg": "The conditional check '_frr_bgp_summary['stdout'] != \"\"' failed. The error was: error while evaluating conditional (_frr_bgp_summary['stdout'] != \"\"): 'dict object' has no attribute 'stdout'\n\nThe error appears to be in '/Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/tasks/monitor.yml': line 44, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- debug: var=_frr_bgp_summary['stdout']\n  ^ here\n"}

    PLAY RECAP *********************************************************************
    ubuntu1804                 : ok=25   changed=0    unreachable=0    failed=1    skipped=13   rescued=0    ignored=0



ERROR:
(default-python-3)

@mrlesmithjr
Copy link
Owner Author

molecule test
--> Validating schema /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/molecule/default/molecule.yml.
Validation completed successfully.
--> Test matrix

└── default
    ├── lint
    ├── cleanup
    ├── destroy
    ├── dependency
    ├── syntax
    ├── create
    ├── prepare
    ├── converge
    ├── idempotence
    ├── side_effect
    ├── verify
    ├── cleanup
    └── destroy

--> Scenario: 'default'
--> Action: 'lint'
--> Executing Yamllint on files found in /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/...
Lint completed successfully.
--> Executing Flake8 on files found in /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/molecule/default/tests/...
Lint completed successfully.
--> Executing Ansible Lint on /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/molecule/default/playbook.yml...
    [601] Don't compare to literal True/False
    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/handlers/main.yml:10
      when: frr_reload != true or _frrdownload.changed

    [601] Don't compare to literal True/False
    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/handlers/main.yml:20
      when: frr_reload == true and not _frrdownload.changed

    [503] Tasks that run when changed should likely be handlers
    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/tasks/config.yml:44
    Task/Handler: config | Flusing Handlers

    [503] Tasks that run when changed should likely be handlers
    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/tasks/config.yml:49
    Task/Handler: config | Rediscovering Facts

    [204] Lines should be no longer than 160 chars
    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/tasks/debian.yml:38
        deb: "{{ frr_package_url }}/frr_{{ frr_version }}{{frr_url_part|default('-1_')}}{{ ansible_distribution|lower }}{{ ansible_distribution_version }}{{frr_url_part_2|default('.1_')}}amd64.deb"

    [206] Variables should have spaces before and after: {{ var_name }}
    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/tasks/debian.yml:38
        deb: "{{ frr_package_url }}/frr_{{ frr_version }}{{frr_url_part|default('-1_')}}{{ ansible_distribution|lower }}{{ ansible_distribution_version }}{{frr_url_part_2|default('.1_')}}amd64.deb"

    [204] Lines should be no longer than 160 chars
    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/tasks/debian.yml:49
            "{{ frr_package_url }}/frr_{{ frr_version }}{{frr_url_part|default('-1_')}}{{ ansible_distribution|lower }}{{ ansible_distribution_major_version }}{{frr_url_part_2|default('.1_')}}armhf.deb",

    [206] Variables should have spaces before and after: {{ var_name }}
    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/tasks/debian.yml:49
            "{{ frr_package_url }}/frr_{{ frr_version }}{{frr_url_part|default('-1_')}}{{ ansible_distribution|lower }}{{ ansible_distribution_major_version }}{{frr_url_part_2|default('.1_')}}armhf.deb",

    [204] Lines should be no longer than 160 chars
    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/tasks/debian.yml:61
            "{{ frr_package_url }}/frr_{{ frr_version }}{{frr_url_part|default('-1_')}}{{ ansible_distribution|lower }}{{ ansible_distribution_version }}{{frr_url_part_2|default('.1_')}}amd64.deb",

    [206] Variables should have spaces before and after: {{ var_name }}
    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/tasks/debian.yml:61
            "{{ frr_package_url }}/frr_{{ frr_version }}{{frr_url_part|default('-1_')}}{{ ansible_distribution|lower }}{{ ansible_distribution_version }}{{frr_url_part_2|default('.1_')}}amd64.deb",

    [204] Lines should be no longer than 160 chars
    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/tasks/debian.yml:71
            "{{ frr_package_url }}/frr_{{ frr_version }}{{frr_url_part|default('-1_')}}{{ ansible_distribution|lower }}{{ ansible_distribution_version }}{{frr_url_part_2|default('.1_')}}armhf.deb",

    [206] Variables should have spaces before and after: {{ var_name }}
    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/tasks/debian.yml:71
            "{{ frr_package_url }}/frr_{{ frr_version }}{{frr_url_part|default('-1_')}}{{ ansible_distribution|lower }}{{ ansible_distribution_version }}{{frr_url_part_2|default('.1_')}}armhf.deb",

    [204] Lines should be no longer than 160 chars
    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/tasks/debian.yml:79
        frr_package_deb: "{{ frr_package_url }}/frr-pythontools_{{ frr_version }}{{ frr_url_part }}{{ ansible_distribution|lower }}{{ ansible_distribution_version }}{{ frr_url_part_3 | default('+1') }}_all.deb"

    [601] Don't compare to literal True/False
    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/tasks/debian.yml:80
      when: frr_reload == true

    [601] Don't compare to literal True/False
    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/tasks/debian.yml:85
      when: frr_reload == true

    [602] Don't compare to empty string
    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/tasks/monitor.yml:47
        - _frr_bgp_summary['stdout'] != ""

    [601] Don't compare to literal True/False
    /Users/larrysmithjr/Git_Projects/Personal/GitHub/mrlesmithjr/ansible-frr/tasks/redhat.yml:44
      when: frr_reload == true


An error occurred during the test sequence action: 'lint'. Cleaning up.
--> Scenario: 'default'
--> Action: 'destroy'

    PLAY [Destroy] *****************************************************************

    TASK [Destroy molecule instance(s)] ********************************************
    changed: [localhost] => (item=None)
    changed: [localhost]

    TASK [Wait for instance(s) deletion to complete] *******************************
    ok: [localhost] => (item=None)
    ok: [localhost]

    TASK [Delete docker network(s)] ************************************************

    PLAY RECAP *********************************************************************
    localhost                  : ok=2    changed=1    unreachable=0    failed=0    skipped=1    rescued=0    ignored=0


(default-python-3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants