-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combining Repos #36
Combining Repos #36
Conversation
fixing bugs yo
more bugfix
fix so neighbor is activated on address family
fixing ipv6 static route bug
adding forwarding and neighbor options
updating readme
updating readme
Merge pull request #38 from floored1585/readme
fixing peer group sorting
ensuring is_peer_group is set before accessed
we need to manage vtysh.conf
prevent empty list items from iterating
This resolves the issue where iteritems() becomes items() in python3. This is to support python3 fully as python 2.7 is EOL starting Jan 1, 2020.
Python3 support
FRR has provided an apt repo for Debian based systems. This allows for an easier install/upgrade path and the existing provisioning has moved to debian_legacy where the new apt install has been created in tasks/debian
Allow for APT REPO
Installs python-frrtools as part of the frr install
Right now the Focal distribution has the most recent FRR. The FRR repos do not support Focal currently, so to get this role to work we must use the default repo for now.
Adding Focal Support
Oh man. This is going to be fun. I'd first start with a rebase from this repo's master branch. Then walk through the conflicts one by one choosing the correct change from the conflict. Then test to ensure things look good from your testing as well. I'd also recommend opening up a collaborative review amongst the other users to see how things might affect them as well. I personally have not used this role in quite some time. I really appreciate all of your hard work as well. 👍 |
debian.yml includes the exact logic needed to deploy frr 7+ with bionic. There very well could be a better and more specific way to address this issue, but bionic does not like debian_legacy due to the specific version definition contained within.
Bionic should include debian.yml
Features: - quagga configration (via routing_type var) - quagga configuration documentation Bug Fixes: - redistribute_v6 is fixed
Allows for Quagga to be configured
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the proposed changes. It looks ok to me. I would vote for merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
The repos have been out of sync for a little while. We've added a lot of functionality in the downstream repo and would like to merge this into this project. Let me know if you have any tips or pointers to getting this done.