Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow install from official FRR RPM repo for RedHat like systems #40

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Allow install from official FRR RPM repo for RedHat like systems #40

merged 1 commit into from
Sep 23, 2020

Conversation

elcomtik
Copy link
Collaborator

This solves issue #38, implemented like 0744dd8

  • used only when FRR version > 7
  • moved legacy install tasks to redhat_legacy.yml
  • introduced vars frr_rpm_version & frr_rpm_repository

@elcomtik
Copy link
Collaborator Author

@mrlesmithjr can you help me with this Travis-ci error? Looks like some version mismatch in molecule, however, I'm not sure how to fix it.

docker.errors.APIError: 400 Client Error: Bad Request ("client version 1.39 is too new. Maximum supported API version is 1.38") The command "molecule test" exited with 1.

@mrlesmithjr
Copy link
Owner

@elcomtik I have added a new branch https://github.com/mrlesmithjr/ansible-frr/tree/feature/refactoring to prepare for new format and Molecule testing. This SHOULD help us long term. Let's ensure that the Molecule tests pass on this branch and then we can merge this branch into master and then rebase.

Sound good?

/cc @nertwork

@elcomtik
Copy link
Collaborator Author

Sound good?

Sure, sounds good. I looked briefly to tests, it's a common structure, which I'm familiar with. Where are you testing it?

@elcomtik
Allow install from official FRR RPM repo for RedHat like systems
39d1463 
- use only when FRR version > 7
- move legacy install tasks to redhat_legacy.yml
- introduced var frr_rpm_version & frr_rpm_repository
@elcomtik
Copy link
Collaborator Author

@mrlesmithjr I rebased my code, tests look good. Would you please merge it?

@elcomtik elcomtik mentioned this pull request Sep 23, 2020
Closed
@mrlesmithjr mrlesmithjr merged commit dffa388 into mrlesmithjr:master Sep 23, 2020
@elcomtik elcomtik mentioned this pull request Sep 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elcomtik @mrlesmithjr