fix: check if file exists before processing #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the VSCode plugin from crashing when an imported css/scss/etc... file does not exist.
mrmckeb
previously approved these changes
Apr 10, 2023
|
Thanks for this, and sorry for the slow turnaround. |
mrmckeb
previously approved these changes
Apr 10, 2023
mrmckeb
approved these changes
Apr 10, 2023
|
@adam-26, as there was a type issue I moved the check up to the plugin root, so we don't call the function if the file doesn't exist. Thanks again for your help! |
mrmckeb
changed the title
calvellido
pushed a commit
to arrow-kt/arrow-website
that referenced
this pull request
Apr 10, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [typescript-plugin-css-modules](https://togithub.com/mrmckeb/typescript-plugin-css-modules) | [`5.0.0` -> `5.0.1`](https://renovatebot.com/diffs/npm/typescript-plugin-css-modules/5.0.0/5.0.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mrmckeb/typescript-plugin-css-modules</summary> ### [`v5.0.1`](https://togithub.com/mrmckeb/typescript-plugin-css-modules/releases/tag/v5.0.1) [Compare Source](https://togithub.com/mrmckeb/typescript-plugin-css-modules/compare/v5.0.0...v5.0.1) **Bug fixes:** - fix: check if file exists before processing ([@​adam-26](https://togithub.com/adam-26), [mrmckeb/typescript-plugin-css-modules#218). **New contributors:** - [@​adam-26](https://togithub.com/adam-26) made their first contribution in [mrmckeb/typescript-plugin-css-modules#218. **Full changelog**: mrmckeb/typescript-plugin-css-modules@v5.0.0...v5.0.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/arrow-kt/arrow-website). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40MC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNDAuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the VSCode plugin from crashing when an imported css/scss/etc... file does not exist.
A more elegant solution would be to check if the file exists before the
readFileSynccall.Will also fix: #216