-
Notifications
You must be signed in to change notification settings - Fork 22
Adding SSVs to sub switching #303
Comments
@waicool20 note that I renamed the |
Need to revise the ship type check for sub switching since SSVs don't have the stats that I think using the ship class kanji would be a better way of distinguishing ships, you could probably also forego going into the stats menu, unless you need the higher res image checking. Could save some time this way. |
@waicool20 Using the kanji was an approach I entertained when I initially created the sub switch module, but is something I ultimately moved away from due to two reasons:
Point 1 is a bit moot now, ever since the I'll definitely give this more thought but the current method might still be the fastest and most efficient generic implementation. I should note that submarines, including SSVs, have a default stat of AA and ASW of 0, which is what kancolle-auto checks for. For the moment I would advise that your SSVs only be equipped w/ equipment that do not alter these two stats. If you have use-case situations where you need SSVs in your fleet, and they have to be equipped with AA/ASW equipment, and they need to be automatically sub-switched, let me know what that situation is and I may be convinced to consider this harder, but I've never encountered this myself. |
I guess I'll equip all my subs with only torps then, and take out any seaplane bombers a sub might have before starting a session. |
Continuing the work started by @waicool20 in #291. Will review fix for #288 here as well.
The text was updated successfully, but these errors were encountered: