-
Notifications
You must be signed in to change notification settings - Fork 22
Conversation
And also got to get Hitomi and Iyo on the list too :p |
Exclusion of SSVs was a deliberate decision (see #234 and #182), but I'm not against the ability of giving users the ability to forcibly include them in the switch sub module. I think with this implementation it'll still keep SSVs out of the rotation even if That said, could you update the image so that it conforms to the other |
I see, how about including images for Kai as well, and options eg. 'i-8_kai'. So in other words add images without the blank space on the right of the name, and name it *_kai.png, if the user enables the Kai variant of the SS then it also enables the base form. |
This seems to work well having a separate kai image, the script is able to choose kai and non-kai variants if the kai image is enabled. I also had to bump up the similarity from 0.9 to 0.95, since I also noticed I-58/I-401 getting mistaken for I-8, so basically same problem as #288. Sadly I couldn't add other subs kai images because I don't have them on hand yet :/ ( Nimu where are you :C ) |
Having the separate kai images is a good way to implement this. One thing is that the text isn't aligned to the right edge of the text, but on the left edge, so for I-8-kai the image should be shifted to the right. The exclusion isn't done by leaving space to the right of the sub's name, but by the ship's class name (text on the left). |
I can also add the images for the other SSVs so no worries on that end. |
Merging in and continuing work in #303. Thanks for the PR! |
Due to recent farming efforts I've finally gotten Shioi :3 wanted to send her to orel duty immediately, and to my surprise she isn't in the sub switching list...