Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change double-negative options #54

Closed
sindresorhus opened this issue Feb 13, 2018 · 2 comments
Closed

Change double-negative options #54

sindresorhus opened this issue Feb 13, 2018 · 2 comments
Assignees

Comments

@sindresorhus
Copy link

Double-negative options is a bad developer experience. It's better to just invert the default.

nobrace => brace
noglobstar => globstar
noext => ext (Or Maybe even extension to be totally clear)
nocase => case

I realize these are brought over from node-glob, but we can do better.


We are now using fast-glob in globby. 😁

@mrmlnc mrmlnc self-assigned this Feb 13, 2018
@mrmlnc
Copy link
Owner

mrmlnc commented Feb 13, 2018

Hello, @sindresorhus,

Yeap, I agree with you that the current naming has problems. Unfortunately, I use those names as options for «backward» compatibility with node-glob and also the same names uses a micromatch.

It seems that we can change this in the next major release.

@mrmlnc
Copy link
Owner

mrmlnc commented Feb 25, 2018

In version 2.1.0 we introduced alternative options for options with the double negation. Please, read release notes for more details.

In the next major release, the options with double-negation will be removed.

@mrmlnc mrmlnc closed this as completed Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants