ISSUE-79: Introduce smoke tests #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmlnc
force-pushed
the
ISSUE-79_smoke_tests
branch
7 times, most recently
from
e7e658e
to
63b5a30
Compare
mrmlnc
force-pushed
the
ISSUE-79_smoke_tests
branch
from
eb56133
to
1335fb9
Compare
Closed
jdalton
reviewed
Mar 16, 2018
src/providers/reader.spec.ts
Outdated
| @@ -153,7 +154,7 @@ describe('Providers → Reader', () => { | |||
|
|
|||
| const entry = tests.getFileEntry(false /** dot */); | |||
|
|
|||
| const expected: string = path.join(process.cwd(), 'fixtures/file.txt'); | |||
There was a problem hiding this comment.
Are results always converted to forward slashes now?
This makes matching slashes paths that are returned harder since Node will normalize slashes in Windows as backslashes. My tests have been failing for a while and I finally found this as the root cause.
As a workaround I've results.map(path.normalize).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
This is an introduction to smoke tests (#79) for the
fast-globpackage.What changes did you make? (Give an overview)
transformaction